Eager loading does not seem to work

[lpe]

I am using gem "acts-as-taggable-on"

Account model : acts_as_taggable_on :categories
account_resource : field :categories, as: :tags, acts_as_taggable_on: :categories
+ self.includes = [:categories]

Does not avoid n+1 on accounts/index :

13:44:54 web.1  |   ActsAsTaggableOn::Tag Load (0.2ms)  SELECT "tags".* FROM "tags" INNER JOIN "taggings" ON "tags"."id" = "taggings"."tag_id" WHERE "taggings"."taggable_id" = $1 AND "taggings"."taggable_type" = $2 AND "taggings"."context" = $3  [["taggable_id", 21683], ["taggable_type", "Account"], ["context", "categories"]]
13:44:54 web.1  |   ActsAsTaggableOn::Tag Load (0.2ms)  SELECT "tags".* FROM "tags" INNER JOIN "taggings" ON "tags"."id" = "taggings"."tag_id" WHERE "taggings"."taggable_id" = $1 AND "taggings"."taggable_type" = $2 AND "taggings"."context" = $3  [["taggable_id", 22716], ["taggable_type", "Account"], ["context", "categories"]]
13:44:54 web.1  |   ActsAsTaggableOn::Tag Load (0.2ms)  SELECT "tags".* FROM "tags" INNER JOIN "taggings" ON "tags"."id" = "taggings"."tag_id" WHERE "taggings"."taggable_id" = $1 AND "taggings"."taggable_type" = $2 AND "taggings"."context" = $3  [["taggable_id", 22803], ["taggable_type", "Account"], ["context", "categories"]]

...
Any idea ?

[adrianthedev]

They seem to be working in the dummy app in the latest version.

Can you try and create a reproduction example that we can check?

web    | Started GET "/admin/resources/posts?view_type=table" for ::1 at 2022-11-15 15:07:40 +0200
web    |   User Load (2.1ms)  SELECT "users".* FROM "users" WHERE "users"."id" = $1 ORDER BY "users"."id" ASC LIMIT $2  [["id", 39], ["LIMIT", 1]]
web    | Processing by Avo::PostsController#index as HTML
web    |   Parameters: {"view_type"=>"table"}
web    |    (0.6ms)  SELECT COUNT(*) FROM "posts"
web    |   Post Load (0.3ms)  SELECT "posts".* FROM "posts" ORDER BY posts.created_at desc LIMIT $1 OFFSET $2  [["LIMIT", 6], ["OFFSET", 0]]
web    |   User Load (0.6ms)  SELECT "users".* FROM "users" WHERE "users"."id" IN ($1, $2, $3, $4, $5, $6)  [["id", 33], ["id", 42], ["id", 24], ["id", 4], ["id", 7], ["id", 9]]
web    |   ActsAsTaggableOn::Tagging Load (0.5ms)  SELECT "taggings".* FROM "taggings" WHERE "taggings"."taggable_type" = $1 AND "taggings"."context" = $2 AND "taggings"."taggable_id" IN ($3, $4, $5, $6, $7, $8)  [["taggable_type", "Post"], ["context", "tags"], ["taggable_id", 37], ["taggable_id", 36], ["taggable_id", 35], ["taggable_id", 34], ["taggable_id", 33], ["taggable_id", 32]]
web    |   ActsAsTaggableOn::Tag Load (0.3ms)  SELECT "tags".* FROM "tags" WHERE "tags"."id" IN ($1, $2, $3, $4)  [["id", 3], ["id", 1], ["id", 2], ["id", 4]]

class PostResource < Avo::BaseResource
  self.includes = [:user, :tags]


  field :tags,
    as: :tags,
    # readonly: true,
    acts_as_taggable_on: :tags,
    close_on_select: false,
    placeholder: "add some tags",
    suggestions: -> { Post.tags_suggestions },
    enforce_suggestions: true,
    help: "The only allowed values here are `one`, `two`, and `three`"
end

[lpe]

Ok I see why ... :-/

I did not see self.includes = [] later in the code.

[adrianthedev]

All good! Glad it worked out 🙌