Skip to content

Commit fc0eeed

Browse files
committed
Remove unused param, remove public where not needed
1 parent 26ebafe commit fc0eeed

File tree

3 files changed

+15
-23
lines changed

3 files changed

+15
-23
lines changed

jsonb-generator/src/main/java/io/avaje/jsonb/generator/FieldReader.java

Lines changed: 9 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ final class FieldReader {
6464
initAliases(element);
6565
}
6666

67-
public void readParam(VariableElement element) {
67+
void readParam(VariableElement element) {
6868
this.deserialize = true;
6969
this.isCreatorParam = true;
7070
initAliases(element);
@@ -251,43 +251,35 @@ public String toString() {
251251
return property.fieldName();
252252
}
253253

254-
public GenericType type() {
254+
GenericType type() {
255255
return property.genericType();
256256
}
257257

258-
public boolean isConstructorParam() {
258+
boolean isConstructorParam() {
259259
return property.isConstructorParam();
260260
}
261261

262-
public String fieldNameWithNum() {
262+
String fieldNameWithNum() {
263263
return property.fieldName() + num;
264264
}
265265

266-
public String adapterFieldName() {
266+
String adapterFieldName() {
267267
return property.adapterFieldName();
268268
}
269269

270-
public MethodReader setter() {
270+
MethodReader setter() {
271271
return property.setter();
272272
}
273273

274-
public void setSetter(MethodReader setter) {
275-
property.setSetterMethod(setter);
276-
}
277-
278-
public void setDeserialize(boolean deserialize) {
279-
this.deserialize = deserialize;
280-
}
281-
282-
public boolean isDeserialize() {
274+
boolean isDeserialize() {
283275
return deserialize;
284276
}
285277

286-
public Map<String, TypeSubTypeMeta> subTypes() {
278+
Map<String, TypeSubTypeMeta> subTypes() {
287279
return subTypes;
288280
}
289281

290-
public List<String> aliases() {
282+
List<String> aliases() {
291283
return aliases;
292284
}
293285

jsonb-generator/src/main/java/io/avaje/jsonb/generator/MethodReader.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,23 +45,23 @@ List<MethodParam> getParams() {
4545
return params;
4646
}
4747

48-
public boolean isPublic() {
48+
boolean isPublic() {
4949
return element.getModifiers().contains(Modifier.PUBLIC);
5050
}
5151

52-
public boolean isProtected() {
52+
boolean isProtected() {
5353
return element.getModifiers().contains(Modifier.PROTECTED);
5454
}
5555

56-
public String creationString() {
56+
String creationString() {
5757
var shortName = Util.shortName(((TypeElement) element.getEnclosingElement()).getQualifiedName().toString());
5858
if (element.getKind() == ElementKind.CONSTRUCTOR) {
5959
return String.format("new %s(", shortName);
6060
}
6161
return String.format("%s.%s(", shortName, element.getSimpleName());
6262
}
6363

64-
public ExecutableElement element() {
64+
ExecutableElement element() {
6565
return element;
6666
}
6767

jsonb-generator/src/main/java/io/avaje/jsonb/generator/TypeReader.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ void read(TypeElement type) {
127127
readField(element, localFields);
128128
break;
129129
case METHOD:
130-
readMethod(element, type, localFields);
130+
readMethod(element, localFields);
131131
break;
132132
}
133133
}
@@ -229,7 +229,7 @@ private void readConstructor(Element element, TypeElement type) {
229229
}
230230
}
231231

232-
private void readMethod(Element element, TypeElement type, List<FieldReader> localFields) {
232+
private void readMethod(Element element, List<FieldReader> localFields) {
233233
ExecutableElement methodElement = (ExecutableElement) element;
234234
if (checkMethod2(methodElement)) {
235235
List<? extends VariableElement> parameters = methodElement.getParameters();

0 commit comments

Comments
 (0)