#16 - Parse error with skipValue() when using internal parser

Author: rbygrave

blackbox-test/src/main/java/org/example/customer/repo/Repo.java

@@ -0,0 +1,9 @@
+package org.example.customer.repo;
+
+import io.avaje.jsonb.Json;
+
+@Json
+public class Repo {
+  public long id;
+  public String name;
+}

blackbox-test/src/test/java/org/example/customer/repo/SkipValueTest.java

@@ -0,0 +1,27 @@
+package org.example.customer.repo;
+
+import io.avaje.jsonb.JsonType;
+import io.avaje.jsonb.Jsonb;
+import org.junit.jupiter.api.Test;
+
+import java.io.InputStream;
+import java.util.List;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+class SkipValueTest {
+
+  Jsonb jsonb = Jsonb.newBuilder().build();
+
+  @Test
+  void test_skipping() {
+    JsonType<List<Repo>> list = jsonb.type(Repo.class).list();
+
+    InputStream is = SkipValueTest.class.getResourceAsStream("/skip-value-test-data.json");
+    List<Repo> repos = list.fromJson(is);
+
+    assertThat(repos).hasSize(9);
+    String asJson = list.toJson(repos);
+    assertThat(asJson).isEqualTo("[{\"id\":1,\"name\":\"n0\"},{\"id\":2,\"name\":\"n1\"},{\"id\":3,\"name\":\"n2\"},{\"id\":4,\"name\":\"n3\"},{\"id\":5,\"name\":\"n4\"},{\"id\":6,\"name\":\"n5\"},{\"id\":7,\"name\":\"n6\"},{\"id\":8,\"name\":\"n7\"},{\"id\":9,\"name\":\"n8\"}]");
+  }
+}

blackbox-test/src/test/resources/skip-value-test-data.json

@@ -0,0 +1,51 @@
+[
+  {
+    "id": 1,
+    "name": "n0",
+    "skip_string": "234"
+  },
+  {
+    "id": 2,
+    "name": "n1",
+    "skip_int": 139
+  },
+  {
+    "id": 3,
+    "name": "n2",
+    "skip_dec": 895.34
+  },
+  {
+    "id": 4,
+    "node_id": "MDEwOlJlcG9zaXRvcnkxNTc2MDI1Mw==",
+    "name": "n3",
+    "skip_object": {
+      "id": 208973,
+      "node_id": "MDQ6VXNlcjIwODk3Mw=="
+    }
+  },
+  {
+    "id": 5,
+    "name": "n4",
+    "skip_array": [1,2,3,4]
+  },
+  {
+    "id": 6,
+    "name": "n5",
+    "skip_null": null
+  },
+  {
+    "id": 7,
+    "name": "n6",
+    "skip_true": true
+  },
+  {
+    "id": 8,
+    "name": "n7",
+    "skip_false": false
+  },
+  {
+    "id": 9,
+    "skip_string": "234",
+    "name": "n8"
+  }
+]

jsonb/src/main/java/io/avaje/jsonb/stream/JParser.java

@@ -746,15 +746,20 @@ private byte skipString() {
     return nextToken();
   }
 
+  @Override
+  public void skipValue() {
+    skipNextValue();
+    // go back one as nextToken() is called next
+    last = buffer[--currentIndex];
+  }
+
   /**
    * Skip to next non-whitespace token (byte)
    * Will not allocate memory while skipping over JSON input.
    *
    * @return next non-whitespace byte
-   * @throws IOException unable to read next byte (end of stream, invalid JSON, ...)
    */
-  @Override
-  public byte skipValue() {
+  private byte skipNextValue() {
     if (last == '"') return skipString();
     if (last == '{') {
       return skipObject();
@@ -782,10 +787,10 @@ public byte skipValue() {
 
   private byte skipArray() {
     nextToken();
-    byte nextToken = skipValue();
+    byte nextToken = skipNextValue();
     while (nextToken == ',') {
       nextToken();
-      nextToken = skipValue();
+      nextToken = skipNextValue();
     }
     if (nextToken != ']') throw newParseError("Expecting ']' for array end");
     return nextToken();
@@ -801,7 +806,7 @@ private byte skipObject() {
     }
     if (nextToken != ':') throw newParseError("Expecting ':' after attribute name");
     nextToken();
-    nextToken = skipValue();
+    nextToken = skipNextValue();
     while (nextToken == ',') {
       nextToken = nextToken();
       if (nextToken == '"') {
@@ -811,7 +816,7 @@ private byte skipObject() {
       }
       if (nextToken != ':') throw newParseError("Expecting ':' after attribute name");
       nextToken();
-      nextToken = skipValue();
+      nextToken = skipNextValue();
     }
     if (nextToken != '}') throw newParseError("Expecting '}' for object end");
     return nextToken();
@@ -968,7 +973,6 @@ public void endObject() {
   private final Formatter errorFormatter = new Formatter(error);
 
   JsonDataException newParseError(final String description) {
-    if (errorInfo == ErrorInfo.MINIMAL) return new JsonDataException(description);
     error.setLength(0);
     error.append(description);
     error.append(". Found ");

jsonb/src/main/java/io/avaje/jsonb/stream/JsonParser.java

@@ -59,7 +59,7 @@ interface JsonParser extends Closeable {
    * This is typically use when we have read <code>nextField()</code>
    * and deemed that we are not interested in the value for that field.
    */
-  byte skipValue();
+  void skipValue();
 
   /**
    * Return true if the value to be read is NULL.