#32 - Non public field org.example.customer.IgnoreField middleName with no matching setter or constructor?

Author: rbygrave

blackbox-test/src/main/java/org/example/customer/IgnoreField.java

@@ -0,0 +1,44 @@
+package org.example.customer;
+
+import io.avaje.jsonb.Json;
+
+@Json
+public class IgnoreField {
+
+  private String firstName;
+
+  @Json.Ignore
+  private String middleName;
+
+  private String lastName;
+
+  public IgnoreField() {
+  }
+
+  public IgnoreField(String firstName, String middleName) {
+    this.firstName = firstName;
+    this.middleName = middleName;
+  }
+
+  public String getFirstName() {
+    return firstName;
+  }
+
+  public IgnoreField setFirstName(String firstName) {
+    this.firstName = firstName;
+    return this;
+  }
+
+  public String getMiddleName() {
+    return middleName;
+  }
+
+  public String getLastName() {
+    return lastName;
+  }
+
+  public IgnoreField setLastName(String lastName) {
+    this.lastName = lastName;
+    return this;
+  }
+}

blackbox-test/src/test/java/org/example/customer/IgnoreFieldTest.java

@@ -0,0 +1,25 @@
+package org.example.customer;
+
+import io.avaje.jsonb.Jsonb;
+import org.junit.jupiter.api.Test;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+class IgnoreFieldTest {
+
+  Jsonb jsonb = Jsonb.builder().build();
+
+  @Test
+  void toJsonFromJson() {
+    var bean = new IgnoreField("fn", "mn");
+    bean.setLastName("ln");
+
+    String asJson = jsonb.toJson(bean);
+    assertThat(asJson).isEqualTo("{\"firstName\":\"fn\",\"lastName\":\"ln\"}");
+
+    IgnoreField fromJson = jsonb.type(IgnoreField.class).fromJson(asJson);
+    assertThat(fromJson.getFirstName()).isEqualTo("fn");
+    assertThat(fromJson.getLastName()).isEqualTo("ln");
+    assertThat(fromJson.getMiddleName()).isNull();
+  }
+}

jsonb-generator/src/main/java/io/avaje/jsonb/generator/FieldReader.java

@@ -100,6 +100,10 @@ boolean includeFromJson() {
     return deserialize;
   }
 
+  boolean includeToJson() {
+    return serialize;
+  }
+
   boolean includeToJson(String type) {
     return serialize && (type == null || subTypes.containsKey(type));
   }

jsonb-generator/src/main/java/io/avaje/jsonb/generator/TypeReader.java

@@ -130,10 +130,12 @@ private void readMethod(Element element, TypeElement type) {
 
   private void matchFieldsToSetterOrConstructor() {
     for (FieldReader field : allFields) {
-      if (constructorParamMap.get(field.fieldName()) != null) {
-        field.constructorParam();
-      } else {
-        matchFieldToSetter(field);
+      if (field.includeFromJson()) {
+        if (constructorParamMap.get(field.fieldName()) != null) {
+          field.constructorParam();
+        } else {
+          matchFieldToSetter(field);
+        }
       }
     }
   }
@@ -189,7 +191,9 @@ private MethodReader setterLookup(String name, boolean loose) {
 
   private void matchFieldsToGetter() {
     for (FieldReader field : allFields) {
-      matchFieldToGetter(field);
+      if (field.includeToJson()) {
+        matchFieldToGetter(field);
+      }
     }
   }