Skip to content

Commit bb0d968

Browse files
committed
Remove unused matchType from addSuperType() + reformat
1 parent 6c135f0 commit bb0d968

File tree

2 files changed

+7
-20
lines changed

2 files changed

+7
-20
lines changed

jsonb-generator/src/main/java/io/avaje/jsonb/generator/BeanReader.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,10 +68,7 @@ boolean isRecord(TypeElement beanType) {
6868
(List<? extends Element>)
6969
TypeElement.class.getMethod("getRecordComponents").invoke(beanType);
7070
return !recordComponents.isEmpty();
71-
} catch (IllegalAccessException
72-
| InvocationTargetException
73-
| NoSuchMethodException
74-
| SecurityException e) {
71+
} catch (IllegalAccessException | InvocationTargetException | NoSuchMethodException | SecurityException e) {
7572
return false;
7673
}
7774
}

jsonb-generator/src/main/java/io/avaje/jsonb/generator/TypeReader.java

Lines changed: 6 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -179,12 +179,7 @@ private void matchFieldToSetter(FieldReader field) {
179179
&& !matchFieldToSetter2(field, true)
180180
&& !matchFieldToSetterByParam(field)
181181
&& !field.isPublicField()) {
182-
logError(
183-
"Non public field "
184-
+ baseType
185-
+ " "
186-
+ field.fieldName()
187-
+ " with no matching setter or constructor?");
182+
logError("Non public field " + baseType + " " + field.fieldName() + " with no matching setter or constructor?");
188183
}
189184
}
190185

@@ -245,12 +240,7 @@ private void matchFieldToGetter(FieldReader field) {
245240
&& !field.isPublicField()) {
246241
nonAccessibleField = true;
247242
if (hasJsonAnnotation) {
248-
logError(
249-
"Non accessible field "
250-
+ baseType
251-
+ " "
252-
+ field.fieldName()
253-
+ " with no matching getter?");
243+
logError("Non accessible field " + baseType + " " + field.fieldName() + " with no matching getter?");
254244
} else {
255245
logDebug("Non accessible field " + baseType + " " + field.fieldName());
256246
}
@@ -357,7 +347,7 @@ void process() {
357347
}
358348
TypeElement superElement = superOf(baseType);
359349
if (superElement != null) {
360-
addSuperType(superElement, null);
350+
addSuperType(superElement);
361351
}
362352
readSubTypes();
363353
processCompleted();
@@ -369,7 +359,7 @@ private void readSubTypes() {
369359
currentSubType = subType;
370360
TypeElement element = element(subType.type());
371361
currentSubType.setElement(element);
372-
addSuperType(element, baseType);
362+
addSuperType(element);
373363
}
374364
}
375365
}
@@ -401,11 +391,11 @@ private void setFieldPositions() {
401391
}
402392
}
403393

404-
private void addSuperType(TypeElement element, TypeElement matchType) {
394+
private void addSuperType(TypeElement element) {
405395
String type = element.getQualifiedName().toString();
406396
if (!JAVA_LANG_OBJECT.equals(type) && !GenericType.isGeneric(type)) {
407397
read(element);
408-
addSuperType(superOf(element), matchType);
398+
addSuperType(superOf(element));
409399
}
410400
}
411401

0 commit comments

Comments
 (0)