Skip to content

Commit 4abbe98

Browse files
committed
Format whitespace, remove unnecessary public modifiers
1 parent 8db0e84 commit 4abbe98

File tree

9 files changed

+53
-86
lines changed

9 files changed

+53
-86
lines changed

jsonb-generator/src/main/java/io/avaje/jsonb/generator/ComponentReader.java

Lines changed: 14 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
package io.avaje.jsonb.generator;
22

3+
import javax.annotation.processing.FilerException;
4+
import javax.lang.model.element.AnnotationMirror;
5+
import javax.lang.model.element.TypeElement;
6+
import javax.lang.model.type.TypeMirror;
7+
import javax.tools.FileObject;
8+
import javax.tools.StandardLocation;
39
import java.io.FileNotFoundException;
410
import java.io.LineNumberReader;
511
import java.io.Reader;
@@ -9,13 +15,6 @@
915
import java.util.List;
1016
import java.util.Optional;
1117

12-
import javax.annotation.processing.FilerException;
13-
import javax.lang.model.element.AnnotationMirror;
14-
import javax.lang.model.element.TypeElement;
15-
import javax.lang.model.type.TypeMirror;
16-
import javax.tools.FileObject;
17-
import javax.tools.StandardLocation;
18-
1918
final class ComponentReader {
2019

2120
private final ProcessingContext ctx;
@@ -47,20 +46,18 @@ private void readMetaData(TypeElement moduleType) {
4746
final FactoryPrism metaDataFactory = FactoryPrism.getInstance(annotationMirror);
4847

4948
if (metaData != null) {
50-
5149
Optional.ofNullable(metaData.value()).stream()
52-
.flatMap(List::stream)
53-
.map(TypeMirror::toString)
54-
.map(this::adapterNameFromEntry)
55-
.forEach(componentMetaData::add);
50+
.flatMap(List::stream)
51+
.map(TypeMirror::toString)
52+
.map(this::adapterNameFromEntry)
53+
.forEach(componentMetaData::add);
5654

5755
} else if (metaDataFactory != null) {
58-
5956
Optional.ofNullable(metaDataFactory.value()).stream()
60-
.flatMap(List::stream)
61-
.map(TypeMirror::toString)
62-
.map(this::adapterNameFromEntry)
63-
.forEach(componentMetaData::add);
57+
.flatMap(List::stream)
58+
.map(TypeMirror::toString)
59+
.map(this::adapterNameFromEntry)
60+
.forEach(componentMetaData::add);
6461
}
6562
}
6663
}

jsonb-generator/src/main/java/io/avaje/jsonb/generator/FieldReader.java

Lines changed: 16 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,9 @@
11
package io.avaje.jsonb.generator;
22

3-
import java.util.LinkedHashMap;
4-
import java.util.List;
5-
import java.util.Map;
6-
import java.util.Objects;
7-
import java.util.Optional;
8-
import java.util.Set;
9-
import java.util.stream.Collectors;
10-
113
import javax.lang.model.element.Element;
124
import javax.lang.model.element.Modifier;
5+
import java.util.*;
6+
import java.util.stream.Collectors;
137

148
final class FieldReader {
159

@@ -37,11 +31,7 @@ final class FieldReader {
3731
private int genericTypeParamPosition;
3832
private final List<String> aliases;
3933

40-
FieldReader(
41-
Element element,
42-
NamingConvention namingConvention,
43-
TypeSubTypeMeta subType,
44-
List<String> genericTypeParams) {
34+
FieldReader(Element element, NamingConvention namingConvention, TypeSubTypeMeta subType, List<String> genericTypeParams) {
4535
addSubType(subType);
4636
this.genericTypeParams = genericTypeParams;
4737
this.fieldName = element.getSimpleName().toString();
@@ -56,19 +46,19 @@ final class FieldReader {
5646
this.deserialize = ignoreReader.deserialize();
5747

5848
this.propertyName =
59-
Optional.ofNullable(PropertyPrism.getInstanceOn(element))
60-
.map(PropertyPrism::value)
61-
.filter(Objects::nonNull)
62-
.map(Util::escapeQuotes)
63-
.orElse(namingConvention.from(fieldName));
49+
Optional.ofNullable(PropertyPrism.getInstanceOn(element))
50+
.map(PropertyPrism::value)
51+
.filter(Objects::nonNull)
52+
.map(Util::escapeQuotes)
53+
.orElse(namingConvention.from(fieldName));
6454
this.aliases =
65-
Optional.ofNullable(JsonAliasPrism.getInstanceOn(element))
66-
.map(JsonAliasPrism::value)
67-
.filter(Objects::nonNull)
68-
.stream()
69-
.flatMap(List::stream)
70-
.map(Util::escapeQuotes)
71-
.collect(Collectors.toList());
55+
Optional.ofNullable(JsonAliasPrism.getInstanceOn(element))
56+
.map(JsonAliasPrism::value)
57+
.filter(Objects::nonNull)
58+
.stream()
59+
.flatMap(List::stream)
60+
.map(Util::escapeQuotes)
61+
.collect(Collectors.toList());
7262

7363
if (raw) {
7464
genericType = GenericType.parse("java.lang.String");
@@ -96,7 +86,7 @@ private String initAdapterShortType(String shortType) {
9686
String typeWrapped = "JsonAdapter<" + PrimitiveUtil.wrap(shortType) + ">";
9787
for (int i = 0; i < genericTypeParams.size(); i++) {
9888
String typeParam = genericTypeParams.get(i);
99-
if (typeWrapped.contains("<" + typeParam + ">") ) {
89+
if (typeWrapped.contains("<" + typeParam + ">")) {
10090
genericTypeParameter = true;
10191
genericTypeParamPosition = i;
10292
typeWrapped = typeWrapped.replace("<" + typeParam + ">", "<Object>");

jsonb-generator/src/main/java/io/avaje/jsonb/generator/NamingConventionReader.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,10 @@ final class NamingConventionReader {
99
private final NamingConvention namingConvention;
1010

1111
NamingConventionReader(TypeElement element) {
12-
1312
final JsonPrism jsonAnnotation = JsonPrism.getInstanceOn(element);
1413
if (jsonAnnotation == null) {
1514
typeProperty = null;
1615
namingConvention = null;
17-
1816
caseInsensitiveKeys = false;
1917
return;
2018
}

jsonb-generator/src/main/java/io/avaje/jsonb/generator/Processor.java

Lines changed: 14 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,5 @@
11
package io.avaje.jsonb.generator;
22

3-
import static io.avaje.jsonb.generator.Constants.JSON;
4-
import static io.avaje.jsonb.generator.Constants.JSON_IMPORT;
5-
import static io.avaje.jsonb.generator.Constants.JSON_MIXIN;
6-
7-
import java.io.IOException;
8-
import java.util.ArrayList;
9-
import java.util.HashSet;
10-
import java.util.List;
11-
import java.util.Set;
12-
import java.util.TreeSet;
13-
143
import javax.annotation.processing.AbstractProcessor;
154
import javax.annotation.processing.ProcessingEnvironment;
165
import javax.annotation.processing.RoundEnvironment;
@@ -20,6 +9,10 @@
209
import javax.lang.model.element.ElementKind;
2110
import javax.lang.model.element.TypeElement;
2211
import javax.lang.model.type.TypeMirror;
12+
import java.io.IOException;
13+
import java.util.*;
14+
15+
import static io.avaje.jsonb.generator.Constants.*;
2316

2417
@SupportedAnnotationTypes({JSON, JSON_IMPORT, JSON_MIXIN})
2518
public final class Processor extends AbstractProcessor {
@@ -103,16 +96,16 @@ private String adapterName(TypeElement element) {
10396

10497
private boolean ignoreType(String type) {
10598
return type.indexOf('.') == -1
106-
|| type.startsWith("java.")
107-
|| type.startsWith("javax.")
108-
|| sourceTypes.contains(type);
99+
|| type.startsWith("java.")
100+
|| type.startsWith("javax.")
101+
|| sourceTypes.contains(type);
109102
}
110103

111-
/** Elements that have a {@code @Json.MixIn} annotation. */
104+
/**
105+
* Elements that have a {@code @Json.MixIn} annotation.
106+
*/
112107
private void writeAdaptersForMixInTypes(Set<? extends Element> mixInElements) {
113-
114108
for (final Element mixin : mixInElements) {
115-
116109
final TypeMirror mirror = MixInPrism.getInstanceOn(mixin).value();
117110
final String importType = mirror.toString();
118111
final TypeElement element = (TypeElement) context.asElement(mirror);
@@ -122,19 +115,17 @@ private void writeAdaptersForMixInTypes(Set<? extends Element> mixInElements) {
122115
}
123116
}
124117

125-
/** Elements that have a {@code @Json.Import} annotation. */
118+
/**
119+
* Elements that have a {@code @Json.Import} annotation.
120+
*/
126121
private void writeAdaptersForImported(Set<? extends Element> importedElements) {
127-
128122
for (final Element importedElement : importedElements) {
129123
for (final TypeMirror importType : ImportPrism.getInstanceOn(importedElement).value()) {
130124
// if imported by mixin annotation skip
131125
if (mixInImports.contains(importType.toString())) {
132126
continue;
133127
}
134-
135-
final TypeElement element = (TypeElement) context.asElement(importType);
136-
137-
writeAdapterForType(element);
128+
writeAdapterForType((TypeElement) context.asElement(importType));
138129
}
139130
}
140131
}

jsonb-generator/src/main/java/io/avaje/jsonb/generator/PropertyIgnoreReader.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,10 @@ final class PropertyIgnoreReader {
1010
private boolean ignoreDeserialize;
1111

1212
PropertyIgnoreReader(Element element) {
13-
1413
unmapped = UnmappedPrism.getInstanceOn(element) != null;
1514
raw = RawPrism.getInstanceOn(element) != null;
1615

1716
final IgnorePrism ignored = IgnorePrism.getInstanceOn(element);
18-
1917
if (ignored != null) {
2018
ignoreDeserialize = !ignored.deserialize();
2119
ignoreSerialize = !ignored.serialize();

jsonb-generator/src/main/java/io/avaje/jsonb/generator/TypeReader.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ final class TypeReader {
4444
this.subTypes = new TypeSubTypeReader(baseType);
4545
}
4646

47-
public TypeReader(TypeElement baseType, TypeElement mixInType, ProcessingContext context, NamingConvention namingConvention) {
47+
TypeReader(TypeElement baseType, TypeElement mixInType, ProcessingContext context, NamingConvention namingConvention) {
4848
this.baseType = baseType;
4949
this.genericTypeParams = initTypeParams(baseType);
5050
this.mixInFields =

jsonb-generator/src/main/java/io/avaje/jsonb/generator/TypeSubTypeMeta.java

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,7 @@
11
package io.avaje.jsonb.generator;
22

3-
import java.util.ArrayList;
4-
import java.util.LinkedHashSet;
5-
import java.util.List;
6-
import java.util.Optional;
7-
import java.util.Set;
8-
93
import javax.lang.model.element.TypeElement;
4+
import java.util.*;
105

116
final class TypeSubTypeMeta {
127

@@ -21,7 +16,7 @@ public String toString() {
2116
return type;
2217
}
2318

24-
public TypeSubTypeMeta(SubTypePrism prism) {
19+
TypeSubTypeMeta(SubTypePrism prism) {
2520
type = prism.type().toString();
2621
name = Optional.of(Util.escapeQuotes(prism.name())).filter(s -> s.length() > 0).orElse(null);
2722
}

jsonb-generator/src/main/java/io/avaje/jsonb/generator/TypeSubTypeReader.java

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
11
package io.avaje.jsonb.generator;
22

3-
import java.util.ArrayList;
4-
import java.util.List;
5-
63
import javax.lang.model.element.AnnotationMirror;
74
import javax.lang.model.element.TypeElement;
5+
import java.util.ArrayList;
6+
import java.util.List;
87

9-
/** Read the @Json.SubType annotations. */
8+
/**
9+
* Read the @Json.SubType annotations.
10+
*/
1011
final class TypeSubTypeReader {
1112

1213
private final TypeElement baseType;
@@ -26,16 +27,13 @@ boolean hasSubTypes() {
2627
}
2728

2829
void read() {
29-
3030
for (final AnnotationMirror mirror : baseType.getAnnotationMirrors()) {
31-
3231
final SubTypePrism subtypePrism = SubTypePrism.getInstance(mirror);
3332
final SubTypesPrism subtypesPrism = SubTypesPrism.getInstance(mirror);
3433

3534
if (subtypePrism != null) {
3635
subTypes.add(new TypeSubTypeMeta(subtypePrism));
3736
} else if (subtypesPrism != null) {
38-
3937
subtypesPrism.value().stream().map(TypeSubTypeMeta::new).forEach(subTypes::add);
4038
}
4139
}

jsonb-generator/src/main/java/io/avaje/jsonb/generator/Util.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ static String initCap(String input) {
5151
}
5252
}
5353

54-
public static String escapeQuotes(String input) {
54+
static String escapeQuotes(String input) {
5555
return input.replaceAll("^\"|\"$", "\\\\\"");
5656
}
5757

0 commit comments

Comments
 (0)