#24 - Change Jsonb.newBuilder() -> Jsonb.builder() with deprecation

Author: rbygrave

README.md

@@ -67,7 +67,7 @@ public record Address(String street, String suburb, String city) { }
 
 ```java
 // build using defaults
-Jsonb jsonb = Jsonb.newBuilder().build();
+Jsonb jsonb = Jsonb.builder().build();
 
 JsonType<Customer> customerType = jsonb.type(Customer.class);
 
@@ -88,7 +88,7 @@ to include when serialising to json.
 For example:
 
 ```java
-Jsonb jsonb = Jsonb.newBuilder().build();
+Jsonb jsonb = Jsonb.builder().build();
 
 JsonType<Customer> customerType = jsonb.type(Customer.class);
 

blackbox-test/src/test/java/org/example/FailOnUnknownTest.java

@@ -15,7 +15,7 @@ void fromJson_default_ignoresUnknown() {
     String jsonContent = "{\"unknown\":\"foo\",\"unknownObject\":{\"a\":\"aval\"},\"unknownList\":[5,6,7],\"id\":42,\"name\":\"hello\"}";
 
     // default skips unknown
-    Jsonb jsonb = Jsonb.newBuilder().build();
+    Jsonb jsonb = Jsonb.builder().build();
     JsonType<Customer> jsonType = jsonb.type(Customer.class);
 
     Customer customer = jsonType.fromJson(jsonContent);
@@ -28,7 +28,7 @@ void fromJson_default_ignoresUnknown() {
   @Test
   void fromJson_with_failOnUnknownTrue() {
     // failOnUnknown set to true
-    Jsonb jsonb = Jsonb.newBuilder().failOnUnknown(true).build();
+    Jsonb jsonb = Jsonb.builder().failOnUnknown(true).build();
     JsonType<Customer> jsonType = jsonb.type(Customer.class);
 
     String jsonContent0 = "{\"unknownScalar\":\"foo\",\"unknownObject\":{\"a\":\"aval\"},\"unknownList\":[5,6,7],\"id\":42,\"name\":\"hello\"}";

blackbox-test/src/test/java/org/example/JsonIgnoreTest.java

@@ -9,7 +9,7 @@
 
 class JsonIgnoreTest {
 
-  Jsonb jsonb = Jsonb.newBuilder().build();
+  Jsonb jsonb = Jsonb.builder().build();
   JsonType<Customer> jsonType = jsonb.type(Customer.class);
 
   @Test

blackbox-test/src/test/java/org/example/customer/BasicPubFieldsTest.java

@@ -9,7 +9,7 @@
 
 class BasicPubFieldsTest {
 
-  Jsonb jsonb = Jsonb.newBuilder().build();
+  Jsonb jsonb = Jsonb.builder().build();
   JsonType<BasicPubFields> type = jsonb.type(BasicPubFields.class);
 
   @Test

blackbox-test/src/test/java/org/example/customer/CustomerTest.java

@@ -4,7 +4,6 @@
 import org.junit.jupiter.api.Test;
 
 import java.io.ByteArrayOutputStream;
-import java.io.OutputStreamWriter;
 import java.io.StringWriter;
 import java.nio.charset.StandardCharsets;
 import java.time.Instant;
@@ -16,7 +15,7 @@ class CustomerTest {
 
   final String jsonStart = "{\"id\":42,\"name\":\"rob\",\"status\":\"ACTIVE\",\"whenCreated\":";
 
-  Jsonb jsonb = Jsonb.newBuilder().build();
+  Jsonb jsonb = Jsonb.builder().build();
 
   @Test
   void anyToJson() {

blackbox-test/src/test/java/org/example/customer/IntegerTest.java

@@ -14,7 +14,7 @@
 
 class IntegerTest {
 
-  private final Jsonb jsonb = Jsonb.newBuilder().build();
+  private final Jsonb jsonb = Jsonb.builder().build();
 
   @Test
   void fromObject()  {

blackbox-test/src/test/java/org/example/customer/MixedCSFTest.java

@@ -16,7 +16,7 @@ void toJson()  {
     mixed.setThree(33L);
     mixed.four = 44L;
 
-    Jsonb jsonb = Jsonb.newBuilder()
+    Jsonb jsonb = Jsonb.builder()
       //.add(MixedCSF.class, MixedCSFJsonAdapter::new)
       .build();
 

blackbox-test/src/test/java/org/example/customer/NestedTest.java

@@ -13,7 +13,7 @@ void toJson()  {
 
     Nested.MyNest bean = new Nested.MyNest(42, "one");
 
-    Jsonb jsonb = Jsonb.newBuilder().build();
+    Jsonb jsonb = Jsonb.builder().build();
 
     JsonType<Nested.MyNest> mixedAdapter = jsonb.type(Nested.MyNest.class);
     String asJson = mixedAdapter.toJson(bean);

blackbox-test/src/test/java/org/example/customer/SomeAddressWrapperTest.java

@@ -12,7 +12,7 @@
 
 class SomeAddressWrapperTest {
 
-  Jsonb jsonb = Jsonb.newBuilder().build();
+  Jsonb jsonb = Jsonb.builder().build();
 
   @Test
   void test_when_null() {
@@ -45,7 +45,7 @@ void includeNull() {
   @Test
   void includeNull_viaJsonB() {
 
-    Jsonb jsonb = Jsonb.newBuilder().serializeNulls(true).build();
+    Jsonb jsonb = Jsonb.builder().serializeNulls(true).build();
 
     var type = jsonb.type(SomeAddressWrapper.class);
     String asJson = type.toJson(new SomeAddressWrapper(43L, null, Collections.emptyList()));
@@ -56,7 +56,7 @@ void includeNull_viaJsonB() {
   @Test
   void includeEmpty_viaJsonB() {
 
-    Jsonb jsonb = Jsonb.newBuilder().serializeEmpty(true).build();
+    Jsonb jsonb = Jsonb.builder().serializeEmpty(true).build();
 
     var type = jsonb.type(SomeAddressWrapper.class);
     String asJson = type.toJson(new SomeAddressWrapper(43L, null));
@@ -67,7 +67,7 @@ void includeEmpty_viaJsonB() {
   @Test
   void includeNullAndEmpty_viaJsonB() {
 
-    Jsonb jsonb = Jsonb.newBuilder().serializeNulls(true).serializeEmpty(true).build();
+    Jsonb jsonb = Jsonb.builder().serializeNulls(true).serializeEmpty(true).build();
 
     var type = jsonb.type(SomeAddressWrapper.class);
     String asJson = type.toJson(new SomeAddressWrapper(43L, null));

blackbox-test/src/test/java/org/example/customer/SomeBinaryTest.java

@@ -13,7 +13,7 @@
 
 class SomeBinaryTest {
 
-  Jsonb jsonb = Jsonb.newBuilder().build();
+  Jsonb jsonb = Jsonb.builder().build();
 
   @Test
   void toJsonFromJson_byteArray() {