Skip to content

Conversation

@anhnv3991
Copy link

@anhnv3991 anhnv3991 commented Sep 16, 2025

Description

@badai-nguyen created an interesting PR that uses CUDA to accelerate the ground-segmentation but the code is not quite optimized and well-organized. I re-organized his code a little bit and fix some minor bugs. Besides, I added some utility functions for allocating/freeing GPU memory.

Related links

Parent Issue:

How was this PR tested?

  • Same as Dai's PR.
  • Execute the cuda_scan_ground_segmenation_node for example:
    ros2 launch autoware_ground_segmentation_cuda cuda_scan_ground_filter.launch.py input/pointcloud:=/sensing/lidar/concatenated/pointcloud
  • Open Rviz2, add the topics /cuda_scan_ground_segmentation_filter/output/ground_pointcloud and /perception/obstacle_segmentation/pointcloud. Those publish the ground and non-ground points on rviz. Set the global options Fixed Frame to base_link. Set the Reliability Policy of Point Cloud topics to Best Effort.
  • Play rosbag which include /sensing/lidar/concatenated/pointcloud topic
    A sample t4_dataset whose input_bag with /sensing/lidar/concatenated/pointcloud topic available could be downloaded from here
  • Download link

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

badai-nguyen and others added 30 commits August 25, 2025 17:17
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Oct 20, 2025
@badai-nguyen
Copy link
Contributor

Note:
I add 35c6835 to add option testing this node together with perception pipeline by enable use_cuda_ground_segmentation

badai-nguyen and others added 6 commits October 24, 2025 11:28
@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 19.40%. Comparing base (97333b0) to head (b3561cb).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11371      +/-   ##
==========================================
+ Coverage   18.88%   19.40%   +0.51%     
==========================================
  Files        1680     1689       +9     
  Lines      114844   115612     +768     
  Branches    39690    40038     +348     
==========================================
+ Hits        21694    22435     +741     
- Misses      75015    75562     +547     
+ Partials    18135    17615     -520     
Flag Coverage Δ *Carryforward flag
daily 21.34% <ø> (+0.01%) ⬆️ Carriedforward from 9dfd826
daily-cuda 18.89% <ø> (+<0.01%) ⬆️ Carriedforward from 9dfd826
differential 5.76% <ø> (?)
total-cuda 18.89% <ø> (ø) Carriedforward from 9dfd826

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

badai-nguyen and others added 4 commits October 31, 2025 00:08
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@badai-nguyen badai-nguyen added the run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Oct 30, 2025
@github-actions
Copy link

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@badai-nguyen badai-nguyen added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) tag:require-cuda-build-and-test and removed run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Oct 31, 2025
badai-nguyen and others added 3 commits October 31, 2025 16:42
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: Anh Nguyen <anhnv.s@hblab.vn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) tag:require-cuda-build-and-test type:documentation Creating or refining documentation. (auto-assigned)

Projects

Status: To Triage

Development

Successfully merging this pull request may close these issues.

3 participants