Skip to content

feat(cuda_pointcloud_preprocessor): update filtering parameter and process #10555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ktro2828
Copy link
Contributor

Description

This PR relates to #10537, and contains the following changes:

  • Modify default value of object_length_threshold = 0.05
  • Remove process checking the number of points inside cluster and num_points_threshold.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
@github-actions github-actions bot added the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label Apr 24, 2025
Copy link

github-actions bot commented Apr 24, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@ktro2828 ktro2828 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Apr 25, 2025
…lier filter

Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
@ktro2828 ktro2828 force-pushed the feat/cuda_pointcloud_preprocessor/parameter-update branch from b1ee8ca to 07f60c5 Compare April 25, 2025 02:32
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.97%. Comparing base (0ff993a) to head (07f60c5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10555      +/-   ##
==========================================
- Coverage   24.97%   24.97%   -0.01%     
==========================================
  Files        1351     1351              
  Lines      105129   105135       +6     
  Branches    39757    39758       +1     
==========================================
  Hits        26260    26260              
- Misses      76378    76384       +6     
  Partials     2491     2491              
Flag Coverage Δ *Carryforward flag
differential-cuda 0.00% <ø> (?)
total 24.97% <ø> (+<0.01%) ⬆️ Carriedforward from 0ff993a

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

1 participant