term_funprint: support bigint

Signed-off-by: Davide Bettio <davide@uninstall.it>

Author: bettio

src/libAtomVM/nifs.c

@@ -44,6 +44,7 @@
 #include "externalterm.h"
 #include "globalcontext.h"
 #include "interop.h"
+#include "intn.h"
 #include "mailbox.h"
 #include "memory.h"
 #include "module.h"
@@ -2185,8 +2186,10 @@ static term nif_erlang_atom_to_list_1(Context *ctx, int argc, term argv[])
 }
 
 static term integer_to_buf(Context *ctx, int argc, term argv[], char *tmp_buf, size_t tmp_buf_size,
-    char **int_buf, size_t *int_len)
+    char **int_buf, size_t *int_len, bool *needs_cleanup)
 {
+    *needs_cleanup = false;
+
     term value = argv[0];
     avm_int_t base = 10;
     VALIDATE_VALUE(value, term_is_any_integer);
@@ -2225,8 +2228,13 @@ static term integer_to_buf(Context *ctx, int argc, term argv[], char *tmp_buf, s
                 break;
             }
 #endif
-            default:
-                abort();
+            default: {
+                size_t boxed_size = term_intn_size(value);
+                size_t digits_per_term = sizeof(term) / sizeof(intn_digit_t);
+                intn_digit_t *dest_buf = (void *) term_intn_data(value);
+                *int_buf = intn_to_string(dest_buf, boxed_size * digits_per_term, base, int_len);
+                *needs_cleanup = true;
+            }
         }
     }
 
@@ -2235,17 +2243,14 @@ static term integer_to_buf(Context *ctx, int argc, term argv[], char *tmp_buf, s
 
 static term nif_erlang_integer_to_binary_2(Context *ctx, int argc, term argv[])
 {
-#ifdef INT64_TO_A_BUF_LEN
     size_t tmp_buf_size = INT64_WRITE_TO_ASCII_BUF_LEN;
-#else
-    size_t tmp_buf_size = INTPTR_WRITE_TO_ASCII_BUF_LEN;
-#endif
     char tmp_buf[tmp_buf_size];
 
     char *int_buf;
     size_t int_len;
+    bool needs_cleanup;
     term maybe_fail_ret
-        = integer_to_buf(ctx, argc, argv, tmp_buf, tmp_buf_size, &int_buf, &int_len);
+        = integer_to_buf(ctx, argc, argv, tmp_buf, tmp_buf_size, &int_buf, &int_len, &needs_cleanup);
     if (UNLIKELY(term_is_invalid_term(maybe_fail_ret))) {
         return maybe_fail_ret;
     }
@@ -2255,27 +2260,36 @@ static term nif_erlang_integer_to_binary_2(Context *ctx, int argc, term argv[])
         RAISE_ERROR(OUT_OF_MEMORY_ATOM);
     }
 
-    return term_from_literal_binary(int_buf, int_len, &ctx->heap, ctx->global);
+    term ret = term_from_literal_binary(int_buf, int_len, &ctx->heap, ctx->global);
+
+    if (needs_cleanup) {
+        free(int_buf);
+    }
+
+    return ret;
 }
 
 static term nif_erlang_integer_to_list_2(Context *ctx, int argc, term argv[])
 {
-#ifdef INT64_TO_A_BUF_LEN
     size_t tmp_buf_size = INT64_WRITE_TO_ASCII_BUF_LEN;
-#else
-    size_t tmp_buf_size = INTPTR_WRITE_TO_ASCII_BUF_LEN;
-#endif
     char tmp_buf[tmp_buf_size];
 
     char *int_buf;
     size_t int_len;
+    bool needs_cleanup;
     term maybe_fail_ret
-        = integer_to_buf(ctx, argc, argv, tmp_buf, tmp_buf_size, &int_buf, &int_len);
+        = integer_to_buf(ctx, argc, argv, tmp_buf, tmp_buf_size, &int_buf, &int_len, &needs_cleanup);
     if (UNLIKELY(term_is_invalid_term(maybe_fail_ret))) {
         return maybe_fail_ret;
     }
 
-    return make_list_from_ascii_buf((uint8_t *) int_buf, int_len, ctx);
+    term ret = make_list_from_ascii_buf((uint8_t *) int_buf, int_len, ctx);
+
+    if (needs_cleanup) {
+        free(int_buf);
+    }
+
+    return ret;
 }
 
 static int format_float(term value, int scientific, int decimals, int compact, char *out_buf, int outbuf_len)

src/libAtomVM/term.c

@@ -22,6 +22,7 @@
 
 #include "atom.h"
 #include "atom_table.h"
+#include "intn.h"
 #include "context.h"
 #include "interop.h"
 #include "module.h"
@@ -393,8 +394,20 @@ int term_funprint(PrinterFun *fun, term t, const GlobalContext *global)
             case 2:
                 return fun->print(fun, AVM_INT64_FMT, term_unbox_int64(t));
 #endif
-            default:
-                AVM_ABORT();
+            default: {
+                size_t digits_per_term = sizeof(term) / sizeof(intn_digit_t);
+                size_t boxed_size = term_intn_size(t);
+                const intn_digit_t *intn_data = (const intn_digit_t *) term_intn_data(t);
+                size_t unused_s_len;
+                char *s
+                    = intn_to_string(intn_data, boxed_size * digits_per_term, 10, &unused_s_len);
+                if (IS_NULL_PTR(s)) {
+                    return -1;
+                }
+                int print_res = fun->print(fun, "%s", s);
+                free(s);
+                return print_res;
+            }
         }
 
     } else if (term_is_float(t)) {

src/libAtomVM/term.h

@@ -870,6 +870,26 @@ static inline size_t term_boxed_integer_size(avm_int64_t value)
     }
 }
 
+static inline term term_create_uninitialized_intn(size_t n, Heap *heap)
+{
+    term *boxed_int = memory_heap_alloc(heap, 1 + n);
+    boxed_int[0] = (n << 6) | TERM_BOXED_POSITIVE_INTEGER; // OR sign bit
+
+    return ((term) boxed_int) | TERM_BOXED_VALUE_TAG;
+}
+
+static inline void *term_intn_data(term t)
+{
+    const term *boxed_value = term_to_const_term_ptr(t);
+    return (void *) (boxed_value + 1);
+}
+
+static inline size_t term_intn_size(term t)
+{
+    const term *boxed_value = term_to_const_term_ptr(t);
+    return term_get_size_from_boxed_header(boxed_value[0]);
+}
+
 static inline term term_from_catch_label(unsigned int module_index, unsigned int label)
 {
     return (term) ((module_index << 24) | (label << 6) | TERM_CATCH_TAG);