Print an error message when trying to use OTP-28 code on v0.6.x

Avoid any kind of frustrating and hard to debug crash.

Signed-off-by: Davide Bettio <davide@uninstall.it>

Author: bettio

src/libAtomVM/module.c

@@ -49,6 +49,7 @@
         return;                                  \
     }
 
+static bool module_are_literals_compressed(const uint8_t *litT);
 #ifdef WITH_ZLIB
     static void *module_uncompress_literals(const uint8_t *litT, int size);
 #endif
@@ -72,6 +73,13 @@ static enum ModuleLoadResult module_populate_atoms_table(Module *this_module, ui
 {
     int atoms_count = READ_32_UNALIGNED(table_data + 8);
 
+    if (UNLIKELY(atoms_count < 0)) {
+        fprintf(stderr, "Code compiled with OTP-28 is not supported by this version of AtomVM.\n"
+                "Please recompile your code using an earlier version, such as OTP-27,\n"
+                "or switch to a newer version of AtomVM, such as a main snapshot.\n");
+        AVM_ABORT();
+    }
+
     const char *current_atom = (const char *) table_data + 12;
 
     this_module->local_atoms_to_global_table = calloc(atoms_count + 1, sizeof(int));
@@ -284,6 +292,11 @@ Module *module_new_from_iff_binary(GlobalContext *global, const void *iff_binary
     module_parse_line_table(mod, beam_file + offsets[LINT] + 8, sizes[LINT]);
 
     if (offsets[LITT]) {
+        if (UNLIKELY(!module_are_literals_compressed(beam_file + offsets[LITT]))) {
+            fprintf(stderr, "Code compiled with OTP-28 is not supported by this version of AtomVM.\n"
+                    "Please recompile your code using an earlier version, such as OTP-27,\n"
+                    "or switch to a newer version of AtomVM, such as a main snapshot.\n");
+        }
         #ifdef WITH_ZLIB
             mod->literals_data = module_uncompress_literals(beam_file + offsets[LITT], sizes[LITT]);
             if (IS_NULL_PTR(mod->literals_data)) {
@@ -364,6 +377,12 @@ COLD_FUNC void module_destroy(Module *module)
     free(module);
 }
 
+static bool module_are_literals_compressed(const uint8_t *litT)
+{
+    uint32_t required_buf_size = READ_32_ALIGNED(litT + LITT_UNCOMPRESSED_SIZE_OFFSET);
+    return (required_buf_size != 0);
+}
+
 #ifdef WITH_ZLIB
 static void *module_uncompress_literals(const uint8_t *litT, int size)
 {

tools/packbeam/packbeam.c

@@ -47,6 +47,7 @@ typedef struct FileData {
 } FileData;
 
 static void pad_and_align(FILE *f);
+bool are_literals_compressed(const uint8_t *litT);
 static void *uncompress_literals(const uint8_t *litT, int size, size_t *uncompressedSize);
 static void add_module_header(FILE *f, const char *module_name, uint32_t flags);
 static void pack_beam_file(FILE *pack, const uint8_t *data, size_t size, const char *filename, int is_entrypoint, bool include_lines);
@@ -340,6 +341,12 @@ static void pack_beam_file(FILE *pack, const uint8_t *data, size_t size, const c
     }
 
     if (offsets[LITT]) {
+        if (UNLIKELY(!are_literals_compressed(data + offsets[LITT]))) {
+            fprintf(stderr, "Code compiled with OTP-28 is not supported by this version of AtomVM.\n"
+                    "Please recompile using an earlier version, such as OTP-27,\n"
+                    "or switch to a newer version of AtomVM, such as a main snapshot.\n");
+            abort();
+        }
         size_t u_size;
         void *deflated = uncompress_literals(data + offsets[LITT], sizes[LITT], &u_size);
         assert_fwrite("LitU", 4, pack);
@@ -419,6 +426,12 @@ static int do_list(int argc, char **argv)
     return ret;
 }
 
+bool are_literals_compressed(const uint8_t *litT)
+{
+    unsigned int required_buf_size = READ_32_ALIGNED(litT + LITT_UNCOMPRESSED_SIZE_OFFSET);
+    return (required_buf_size != 0);
+}
+
 static void *uncompress_literals(const uint8_t *litT, int size, size_t *uncompressedSize)
 {
     unsigned int required_buf_size = READ_32_ALIGNED(litT + LITT_UNCOMPRESSED_SIZE_OFFSET);