ets: rename entry to tuple in insert

Signed-off-by: Jakub Gonet <jakub.gonet@swmansion.com>

Author: jgonet

src/libAtomVM/ets.c

@@ -247,21 +247,22 @@ static void ets_delete_all_tables(struct Ets *ets, GlobalContext *global)
     ets_delete_tables_internal(ets, true_pred, NULL, global);
 }
 
-static EtsErrorCode insert(struct EtsTable *ets_table, term entry, Context *ctx)
+static EtsErrorCode insert(struct EtsTable *ets_table, term tuple, Context *ctx)
 {
-    size_t keypos = ets_table->key_index;
-
-    if ((size_t) term_get_tuple_arity(entry) <= keypos) {
+    assert(term_is_tuple(tuple));
+    size_t key_index = ets_table->key_index;
+    if ((size_t) term_get_tuple_arity(tuple) <= key_index) {
         return EtsBadEntry;
     }
 
-    struct HNode *new_node = ets_hashtable_new_node(entry, keypos);
+    struct HNode *new_node = ets_hashtable_new_node(tuple, key_index);
     if (IS_NULL_PTR(new_node)) {
         return EtsAllocationFailure;
     }
 
     EtsHashtableStatus res = ets_hashtable_insert(ets_table->hashtable, new_node, EtsHashtableAllowOverwrite, ctx->global);
     if (UNLIKELY(res != EtsHashtableOk)) {
+        ets_hashtable_free_node(new_node, ctx->global);
         return EtsAllocationFailure;
     }
 

src/libAtomVM/ets_hashtable.c

@@ -87,19 +87,19 @@ static void print_info(struct EtsHashTable *hash_table)
 }
 #endif
 
-struct HNode *ets_hashtable_new_node(term entry, int key_index)
+struct HNode *ets_hashtable_new_node(term tuple, int key_index)
 {
     struct HNode *new_node = malloc(sizeof(struct HNode));
     if (IS_NULL_PTR(new_node)) {
         goto cleanup;
     }
 
-    size_t size = memory_estimate_usage(entry);
+    size_t size = memory_estimate_usage(tuple);
     if (UNLIKELY(memory_init_heap(&new_node->heap, size) != MEMORY_GC_OK)) {
         goto cleanup;
     }
 
-    term new_entry = memory_copy_term_tree(&new_node->heap, entry);
+    term new_entry = memory_copy_term_tree(&new_node->heap, tuple);
     assert(term_is_tuple(new_entry));
     assert(term_get_tuple_arity(new_entry) >= key_index);
     term key = term_get_tuple_element(new_entry, key_index);