Merge pull request #1552 from bettio/biggerint

Add bigint (256 bit + sign) initial scaffolding

This PR introduces support to signed 256 bit integers.

Briefly:
- Add code for generic big integer handling (`intn.c`), limited to 256 bit for
the sake of simplicity, but it might be expanded to generic big integers with
some additional work
- Refactored arithmetic BIF helpers
- Refactored `integer_to_binary`/`_to_list` in order to reduce both code
duplication and make it simpler adding big integers support
- Reimplemented `binary_to_integer` in to make it compliant with OTP (binaries
such as `<<"0xCAFE">>` or `<<"  42">>` must be rejected).
- Replaced `lltoa` with more performant functions that do not rely on slow
helpers, specially for base 10 and 16
- Added bigint support to '*' operator
- Boxed integers can be either positive and negative; also added predicates for
checking signed type
- Added support for big literals
- Added support for big integers to `binary_to_term` and `term_to_binary`

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

Author: bettio

.github/workflows/build-and-test.yaml

@@ -380,7 +380,7 @@ jobs:
       working-directory: build
       run: |
         ulimit -c unlimited
-        valgrind --error-exitcode=1 ./tests/test-erlang -s prime_smp
+        valgrind --suppressions=../tests/valgrind-suppressions.sup --error-exitcode=1 ./tests/test-erlang -s prime_smp
         ./tests/test-erlang -s prime_smp
 
     - name: "Test: test-enif"
@@ -418,30 +418,30 @@ jobs:
       run: |
         ulimit -c unlimited
         ./src/AtomVM ./tests/libs/etest/test_etest.avm
-        valgrind ./src/AtomVM ./tests/libs/etest/test_etest.avm
+        valgrind --suppressions=../tests/valgrind-suppressions.sup ./src/AtomVM ./tests/libs/etest/test_etest.avm
 
     - name: "Test: test_estdlib.avm"
       timeout-minutes: 5
       working-directory: build
       run: |
         ulimit -c unlimited
-        valgrind --error-exitcode=1 ./src/AtomVM ./tests/libs/estdlib/test_estdlib.avm
+        valgrind --suppressions=../tests/valgrind-suppressions.sup --error-exitcode=1 ./src/AtomVM ./tests/libs/estdlib/test_estdlib.avm
         ./src/AtomVM ./tests/libs/estdlib/test_estdlib.avm
 
     - name: "Test: test_eavmlib.avm"
       timeout-minutes: 10
       working-directory: build
       run: |
         ulimit -c unlimited
-        valgrind --error-exitcode=1 ./src/AtomVM ./tests/libs/eavmlib/test_eavmlib.avm
+        valgrind --suppressions=../tests/valgrind-suppressions.sup --error-exitcode=1 ./src/AtomVM ./tests/libs/eavmlib/test_eavmlib.avm
         ./src/AtomVM ./tests/libs/eavmlib/test_eavmlib.avm
 
     - name: "Test: test_alisp.avm"
       timeout-minutes: 10
       working-directory: build
       run: |
         ulimit -c unlimited
-        valgrind --error-exitcode=1 ./src/AtomVM ./tests/libs/alisp/test_alisp.avm
+        valgrind --suppressions=../tests/valgrind-suppressions.sup --error-exitcode=1 ./src/AtomVM ./tests/libs/alisp/test_alisp.avm
         ./src/AtomVM ./tests/libs/alisp/test_alisp.avm
 
     - name: "Test: Tests.avm (Elixir)"
@@ -451,7 +451,7 @@ jobs:
         ulimit -c unlimited
         if command -v elixirc >/dev/null 2>&1 && command -v elixir >/dev/null 2>&1
         then
-          valgrind --error-exitcode=1 ./src/AtomVM ./tests/libs/exavmlib/Tests.avm
+          valgrind --suppressions=../tests/valgrind-suppressions.sup --error-exitcode=1 ./src/AtomVM ./tests/libs/exavmlib/Tests.avm
           ./src/AtomVM ./tests/libs/exavmlib/Tests.avm
         else
           echo "Elixir not installed, skipping Elixir tests"

CHANGELOG.md

@@ -29,6 +29,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Added `erlang:unique_integer/0` and `erlang:unique_integer/1`
 - Added support for 'ets:delete/1'.
 
+### Changed
+- `binary_to_integer/1` no longer accepts binaries such as `<<"0xFF">>` or `<<"  123">>`
+
 ### Fixed
 - ESP32: improved sntp sync speed from a cold boot.
 - Utilize reserved `phy_init` partition on ESP32 to store wifi calibration for faster connections.

src/libAtomVM/CMakeLists.txt

@@ -42,6 +42,7 @@ set(HEADER_FILES
     globalcontext.h
     iff.h
     interop.h
+    intn.h
     list.h
     listeners.h
     mailbox.h
@@ -89,6 +90,7 @@ set(SOURCE_FILES
     globalcontext.c
     iff.c
     interop.c
+    intn.c
     mailbox.c
     memory.c
     module.c
@@ -102,6 +104,7 @@ set(SOURCE_FILES
     term.c
     timer_list.c
     unicode.c
+    utils.c
     valueshashtable.c
 )