Merge pull request #1573 from bettio/improve-ci-valgrind-step

Improve CI valgrind step

1. fail when valgrind detects a memory error
2. run valgrind first, to make easier to deal with bugs and crashes

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

Author: bettio

.github/workflows/build-and-test.yaml

@@ -332,61 +332,61 @@ jobs:
       working-directory: build
       run: |
         ulimit -c unlimited
+        valgrind --error-exitcode=1 ./tests/test-erlang -s prime_smp
         ./tests/test-erlang -s prime_smp
-        valgrind ./tests/test-erlang -s prime_smp
 
     - name: "Test: test-enif"
       working-directory: build
       run: |
         ulimit -c unlimited
+        valgrind --error-exitcode=1 ./tests/test-enif
         ./tests/test-enif
-        valgrind ./tests/test-enif
 
     - name: "Test: test-heap"
       working-directory: build
       run: |
         ulimit -c unlimited
+        valgrind --error-exitcode=1 ./tests/test-heap
         ./tests/test-heap
-        valgrind ./tests/test-heap
 
     - name: "Test: test-mailbox"
       working-directory: build
       run: |
         ulimit -c unlimited
+        valgrind --error-exitcode=1 ./tests/test-mailbox
         ./tests/test-mailbox
-        valgrind ./tests/test-mailbox
 
     - name: "Test: test-structs"
       timeout-minutes: 10
       working-directory: build
       run: |
         ulimit -c unlimited
+        valgrind --error-exitcode=1 ./tests/test-structs
         ./tests/test-structs
-        valgrind ./tests/test-structs
 
     - name: "Test: test_estdlib.avm"
       timeout-minutes: 5
       working-directory: build
       run: |
         ulimit -c unlimited
+        valgrind --error-exitcode=1 ./src/AtomVM ./tests/libs/estdlib/test_estdlib.avm
         ./src/AtomVM ./tests/libs/estdlib/test_estdlib.avm
-        valgrind ./src/AtomVM ./tests/libs/estdlib/test_estdlib.avm
 
     - name: "Test: test_eavmlib.avm"
       timeout-minutes: 10
       working-directory: build
       run: |
         ulimit -c unlimited
+        valgrind --error-exitcode=1 ./src/AtomVM ./tests/libs/eavmlib/test_eavmlib.avm
         ./src/AtomVM ./tests/libs/eavmlib/test_eavmlib.avm
-        valgrind ./src/AtomVM ./tests/libs/eavmlib/test_eavmlib.avm
 
     - name: "Test: test_alisp.avm"
       timeout-minutes: 10
       working-directory: build
       run: |
         ulimit -c unlimited
+        valgrind --error-exitcode=1 ./src/AtomVM ./tests/libs/alisp/test_alisp.avm
         ./src/AtomVM ./tests/libs/alisp/test_alisp.avm
-        valgrind ./src/AtomVM ./tests/libs/alisp/test_alisp.avm
 
     - name: "Test: Tests.avm (Elixir)"
       timeout-minutes: 10
@@ -395,8 +395,8 @@ jobs:
         ulimit -c unlimited
         if command -v elixirc &> /dev/null
         then
+          valgrind --error-exitcode=1 ./src/AtomVM ./tests/libs/exavmlib/Tests.avm
           ./src/AtomVM ./tests/libs/exavmlib/Tests.avm
-          valgrind ./src/AtomVM ./tests/libs/exavmlib/Tests.avm
         fi
 
     - name: "Install and smoke test"

.github/workflows/build-libraries.yaml

@@ -75,8 +75,8 @@ jobs:
       timeout-minutes: 10
       working-directory: build
       run: |
+        valgrind --error-exitcode=1 ./src/AtomVM ./tests/libs/estdlib/test_estdlib.avm
         ./src/AtomVM ./tests/libs/estdlib/test_estdlib.avm
-        valgrind ./src/AtomVM ./tests/libs/estdlib/test_estdlib.avm
 
     - name: "Rename and write sha256sum"
       working-directory: build