Merge pull request #1699 from jgonet/jgonet/fix-test-warnings

Fix tests warnings

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

Author: bettio

tests/erlang_tests/test_funs12.erl

@@ -41,7 +41,7 @@ check_guard(A, B, A) when is_function(B, A) ->
     A;
 check_guard(A, _B, A) when A < 0 ->
     error;
-check_guard(_A, _B, _A) ->
+check_guard(_, _, _) ->
     false.
 
 discard(_X) ->

tests/erlang_tests/unique.erl

@@ -20,14 +20,15 @@
 
 -module(unique).
 
--export([start/0, id/1, check_error/3]).
+-export([start/0, id/1]).
 
 start() ->
     ok = unique_0(),
     ok = unique_positive(),
     ok = unique_monotonic(),
     ok = unique_positive_monotonic(),
     ok = unique_monotonic_processes(),
+    ok = invalid_args(),
 
     Self = self(),
     N = length([
@@ -39,15 +40,19 @@ start() ->
     receive_messages(N),
     0.
 
-test_invalid() ->
-    ok = ?MODULE:check_error(fun() -> erlang:unique_integer(?MODULE:id(5)) end),
-    ok = ?MODULE:check_error(fun() -> erlang:unique_integer(?MODULE:id([positive | monotonic])) end).
+invalid_args() ->
+    ok = raises(badarg, fun() -> erlang:unique_integer(?MODULE:id(5)) end),
+    ok = raises(badarg, fun() ->
+        erlang:unique_integer(?MODULE:id([positive | monotonic]))
+    end),
+    ok.
 
-check_error(F, A, B) ->
+raises(Reason, F) ->
     try F() of
         Result -> {unexpected, Result}
     catch
-        A:B -> ok
+        error:Reason -> ok;
+        E:R -> {unexpected, E, R}
     end.
 
 id(X) ->

tests/libs/exavmlib/Tests.ex

@@ -182,7 +182,7 @@ defmodule Tests do
 
   defp test_enum_chunk_while() do
     initial_col = 4
-    lines_list = '-1234567890\nciao\n12345\nabcdefghijkl\n12'
+    lines_list = ~c"-1234567890\nciao\n12345\nabcdefghijkl\n12"
     columns = 5
 
     chunk_fun = fn char, {count, rchars} ->
@@ -198,7 +198,7 @@ defmodule Tests do
       {_count, rchars} -> {:cont, Enum.reverse(rchars), []}
     end
 
-    ['-', '12345', '67890', 'ciao', '12345', 'abcde', 'fghij', 'kl', '12'] =
+    [~c"-", ~c"12345", ~c"67890", ~c"ciao", ~c"12345", ~c"abcde", ~c"fghij", ~c"kl", ~c"12"] =
       Enum.chunk_while(lines_list, {initial_col, []}, chunk_fun, after_fun)
   end
 
@@ -291,10 +291,10 @@ defmodule Tests do
     "[]" = inspect([])
     "[0]" = inspect([0])
     "[9, 10]" = inspect([9, 10])
-    ~s'["test"]' = inspect(["test"])
-    "'hello'" = inspect('hello')
+    ~s(["test"]) = inspect(["test"])
+    "'hello'" = inspect(~c"hello")
     "[127]" = inspect([127])
-    "[104, 101, 108, 108, 248]" = inspect('hellø')
+    "[104, 101, 108, 108, 248]" = inspect(~c"hellø")
 
     ~s([5 | "hello"]) = inspect([5 | "hello"])