Skip to content

Commit 715c590

Browse files
committed
Minor changes + exclude template test dir from pnpm workspace
1 parent e7130de commit 715c590

File tree

6 files changed

+8
-258
lines changed

6 files changed

+8
-258
lines changed

browser/data-browser/src/components/forms/NewForm/CustomCreateActions/CustomForms/NewDriveDialog.tsx

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import {
88
Dialog,
99
DialogContent,
1010
DialogActions,
11+
DialogTitle,
1112
} from '../../../../Dialog';
1213
import Field from '../../../Field';
1314
import { InputWrapper, InputStyled } from '../../../InputStyles';
@@ -53,7 +54,7 @@ export const NewDriveDialog: FC<CustomResourceDialogProps> = ({
5354
await agentResource.save();
5455

5556
// Create a default ontology.
56-
const ontologyName = stringToSlug(name);
57+
const ontologyName = stringToSlug(name.trim());
5758
const ontology = await store.newResource({
5859
subject: await store.buildUniqueSubjectFromParts(
5960
['defaultOntology'],
@@ -99,7 +100,9 @@ export const NewDriveDialog: FC<CustomResourceDialogProps> = ({
99100

100101
return (
101102
<Dialog {...dialogProps}>
102-
<H1>New Drive</H1>
103+
<DialogTitle>
104+
<H1>New Drive</H1>
105+
</DialogTitle>
103106
<DialogContent>
104107
<form
105108
onSubmit={(e: FormEvent) => {

browser/data-browser/src/views/TablePage/TablePage.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ export function TablePage({ resource }: ResourcePageProps): JSX.Element {
133133
<FaCode />
134134
</IconButton>
135135
<IconButton
136-
title='Use in code'
136+
title='Export to CSV'
137137
onClick={() => setShowExportDialog(true)}
138138
>
139139
<FaFileCsv />

browser/e2e/tests/tables.spec.ts

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -223,16 +223,6 @@ test.describe('tables', async () => {
223223
await fillRow(index + 1, row);
224224
}
225225

226-
// Disabled date tests until Playwright bug fixed
227-
// await expect(
228-
// page.getByRole('gridcell', { name: '4 March 2000' }),
229-
// ).toBeVisible();
230-
// await expect(
231-
// page.getByRole('gridcell', { name: '15 May 1980' }),
232-
// ).toBeVisible();
233-
// await expect(
234-
// page.getByRole('gridcell', { name: '13 May 1965' }),
235-
// ).toBeVisible();
236226
await expect(
237227
page.getByRole('gridcell', { name: '😵‍💫 dreamy' }),
238228
).toBeVisible();

browser/e2e/tests/test-utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ export async function openAtomic(page: Page) {
188188
export async function editProfileAndCommit(page: Page) {
189189
await openAgentPage(page);
190190
await page.click('text=Edit profile');
191-
const advancedButton = await page.getByRole('button', { name: 'advanced' });
191+
const advancedButton = page.getByRole('button', { name: 'advanced' });
192192
await advancedButton.scrollIntoViewIfNeeded();
193193
await advancedButton.click();
194194
await expect(page.locator('text=add another property')).toBeVisible();

0 commit comments

Comments
 (0)