Merge pull request #20 from jeffjennings/download_text

adrn · web-flow · commit ffa9c8b849f5 · 2024-10-30T15:44:34.000-04:00
More verbose 'download' text on website tutorial pages
diff --git a/nbcollection/themes/learnastropy/templates/html/astropy-header.html.j2 b/nbcollection/themes/learnastropy/templates/html/astropy-header.html.j2
@@ -12,7 +12,7 @@
     <a href="{{ resources['learn_astropy_source_url'] }}">{{ resources["learn_astropy_source_label"] or "View on GitHub" }}</a>
     {% endif %}
     {% if resources.learn_astropy_ipynb_download_url %}
-    <a href="{{ resources['learn_astropy_ipynb_download_url'] }}" download>Download</a>
+    <a href="{{ resources['learn_astropy_ipynb_download_url'] }}" download>Download this notebook</a>
     {% endif %}
   </nav>
 </header>
diff --git a/tests/test_cli.py b/tests/test_cli.py
@@ -147,7 +147,7 @@ def test_learn_astropy_theme(tmp_path):
     assert github_link.attrs["href"] == (
         "https://github.com/astropy/astropy-tutorials/blob/main/tutorials/notebook1.ipynb"
     )
-    download_link = header_nav.find("a", string="Download")
+    download_link = header_nav.find("a", string="Download this notebook")
     assert download_link.attrs["href"] == "notebook1.ipynb"
 
 

Original file line number	Diff line number	Diff line change
`@@ -147,7 +147,7 @@ def test_learn_astropy_theme(tmp_path):`
`147`	`147`	`assert github_link.attrs["href"] == (`
`148`	`148`	`"https://github.com/astropy/astropy-tutorials/blob/main/tutorials/notebook1.ipynb"`
`149`	`149`	`)`
`150`		`- download_link = header_nav.find("a", string="Download")`
	`150`	`+ download_link = header_nav.find("a", string="Download this notebook")`
`151`	`151`	`assert download_link.attrs["href"] == "notebook1.ipynb"`
`152`	`152`
`153`	`153`