Skip to content

Commit eef3fc2

Browse files
authored
update cargo-dist and enable ci checks (#12949)
Fixes #12881 Potentially Fixes #12780 Prevents #12879
1 parent 451c834 commit eef3fc2

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

.github/workflows/release.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ permissions:
4040
# If there's a prerelease-style suffix to the version, then the release(s)
4141
# will be marked as a prerelease.
4242
on:
43+
pull_request:
4344
workflow_dispatch:
4445
inputs:
4546
tag:
@@ -68,7 +69,7 @@ jobs:
6869
# we specify bash to get pipefail; it guards against the `curl` command
6970
# failing. otherwise `sh` won't catch that `curl` returned non-0
7071
shell: bash
71-
run: "curl --proto '=https' --tlsv1.2 -LsSf https://github.com/astral-sh/cargo-dist/releases/download/v0.28.4-prerelease.1/cargo-dist-installer.sh | sh"
72+
run: "curl --proto '=https' --tlsv1.2 -LsSf https://github.com/astral-sh/cargo-dist/releases/download/v0.28.4/cargo-dist-installer.sh | sh"
7273
- name: Cache dist
7374
uses: actions/upload-artifact@6027e3dd177782cd8ab9af838c04fd81a07f1d47
7475
with:

Cargo.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,7 @@ inherits = "release"
294294
# Config for 'dist'
295295
[workspace.metadata.dist]
296296
# The preferred dist version to use in CI (Cargo.toml SemVer syntax)
297-
cargo-dist-version = "0.28.4-prerelease.1"
297+
cargo-dist-version = "0.28.4"
298298
# make a package being included in our releases opt-in instead of opt-out
299299
dist = false
300300
# CI backends to support
@@ -330,7 +330,7 @@ auto-includes = false
330330
# Whether dist should create a Github Release or use an existing draft
331331
create-release = true
332332
# Which actions to run on pull requests
333-
pr-run-mode = "skip"
333+
pr-run-mode = "plan"
334334
# Whether CI should trigger releases with dispatches instead of tag pushes
335335
dispatch-releases = true
336336
# Which phase dist should use to create the GitHub release

0 commit comments

Comments
 (0)