Skip to content

Commit 9c3c40a

Browse files
committed
Update pubgrub to new add_incompatibility_from_dependencies
We had previously changed the signature of `DependencyProvider::get_dependencies` to return an iterator instead of a hashmap to avoid the conversion cost from our dependencies `Vec` to the pubgrub's hashmap. These changes are difficult to make in pubgrub since they complicate the public api. But we don't actually use `DependencyProvider::get_dependencies`, so we rolled those customizations back in pubgrub-rs/pubgrub#226 and instead opted to change only the internal `add_incompatibility_from_dependencies` method that we exposed in our fork. This aligns us closer with upstream, removes the design questions about `DependencyProvider` from our concerns and reduces our diff (not counting the github action) to +36 -12.
1 parent 191f955 commit 9c3c40a

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

Cargo.lock

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ path-slash = { version = "0.2.1" }
100100
pathdiff = { version = "0.2.1" }
101101
petgraph = { version = "0.6.4" }
102102
platform-info = { version = "2.0.2" }
103-
pubgrub = { git = "https://github.com/astral-sh/pubgrub", rev = "d4795a31be17669aba11eb741b4a9086acc3eb11" }
103+
pubgrub = { git = "https://github.com/astral-sh/pubgrub", rev = "a68cbd1a26e43986a31563e1d127e83bafca3a0c" }
104104
pyo3 = { version = "0.21.0" }
105105
pyo3-log = { version = "0.10.0" }
106106
rayon = { version = "1.8.0" }

crates/uv-resolver/src/dependency_provider.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ impl DependencyProvider for UvDependencyProvider {
3838
&self,
3939
_package: &Self::P,
4040
_version: &Self::V,
41-
) -> Result<Dependencies<Vec<(Self::P, Self::VS)>, Self::M>, Self::Err> {
41+
) -> Result<Dependencies<Self::P, Self::VS, Self::M>, Self::Err> {
4242
unimplemented!()
4343
}
4444
}

0 commit comments

Comments
 (0)