Unable to build v0.0.248 with rustc 1.67.0

[winterqt]

When building Ruff v0.0.248 with rustc 1.67.0, I receive the following compilation error:

error[E0080]: evaluation of constant value failed
   --> crates/ruff_formatter/src/utility_types.rs:5:24
    |
5   |         const _: i32 = 0 / $expr as i32;
    |                        ^^^^^^^^^^^^^^^^ attempt to divide `0_i32` by zero
    |
   ::: crates/ruff_formatter/src/format_element.rs:388:1
    |
388 | static_assert!(std::mem::size_of::<crate::FormatElement>() == 24usize);
    | ---------------------------------------------------------------------- in this macro invocation
    |
    = note: this error originates in the macro `static_assert` (in Nightly builds, run with -Z macro-backtrace for more info)

rustc 1.67.0 (fc594f156 2023-01-24) (built from a source tarball)
binary: rustc
commit-hash: fc594f15669680fa70d255faec3ca3fb507c3405
commit-date: 2023-01-24
host: aarch64-apple-darwin
release: 1.67.0
LLVM version: 15.0.7

[figsoda]

I ran into a similar but different issue on x86_64 linux for both rust 1.67.0 and nightly

error: `T` does not live long enough
  --> crates/ruff_python_formatter/src/shared_traits.rs:36:9
   |
36 |         self.as_ref().map(AsFormat::format)
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: could not compile `ruff_python_formatter` due to previous error
warning: build failed, waiting for other jobs to finish...

rustc 1.67.0 (fc594f156 2023-01-24) (built from a source tarball)
binary: rustc
commit-hash: fc594f15669680fa70d255faec3ca3fb507c3405
commit-date: 2023-01-24
host: x86_64-unknown-linux-gnu
release: 1.67.0
LLVM version: 15.0.7

rustc 1.69.0-nightly (4507fdaaa 2023-02-18)
binary: rustc
commit-hash: 4507fdaaa27ea2fb59a41df2ce7d1f290da53dae
commit-date: 2023-02-18
host: x86_64-unknown-linux-gnu
release: 1.69.0-nightly
LLVM version: 15.0.7

[charliermarsh]

Hmm, it's probably not a new error, but might be a result of changing our default members. Can you try cargo build -p ruff_cli?

[charliermarsh]

(Though of course we should fix those. I can take a look.)

[winterqt]

If it helps, this could have occurred at any point between 0.0.245 and 248. If you'd like, I can bisect.

[figsoda]

For my error, the regression happened at the 1.66.0 release

nix shell fenix/6369e55b8ba49b896da496c06013d7cb0d1395c6#stable.minimalToolchain nixpkgs#gnumake -c cargo build

works, but the same command fails on nix-community/fenix@d3eaf97

https://blog.rust-lang.org/2022/12/15/Rust-1.66.0.html

[charliermarsh]

Thanks, taking a look now. We build on 1.65.0, I see the same issue as @figsoda on 1.66.0.

[charliermarsh]

I can't reproduce @winterqt's issue though.

[winterqt]

@charliermarsh On Linux, or macOS?

[charliermarsh]

macOS, Rust 1.67.0. Let me try a cargo clean though.

[charliermarsh]

Still no luck, any ideas?

[winterqt]

Sorry, to be clear: aarch64 macOS or x86_64?

[charliermarsh]

Oh sorry, aarch64 :)