Rule suggestion: unecessary multiple calls to function

[njourdane]

On several occasions, I have realized that I was calling a function/method returning an iterable on each item inside a loop.

Does this rule makes sense for you to prevent this?

filtered_things = [get_things()[key] for key in ["a", "b", "c"]] # bad: unecessary multiple calls to get_things()

things = get_things()
filtered_things = [things[key] for key in ["a", "b", "c"]] # good

get_things() might do something else that returning the iterable, but in that case I would prefer to get the warning anyway and ignore the rule explicitly on the line.

[ntBre]

This seems like it could be quite difficult to detect reliably, possibly even with type information, but thank you for the suggestion!