Merge branch 'main' into dcreager/legacy-class

* main:
  [red-knot] Refactor: no mutability in call APIs (#17788)
  [red-knot] Fix panic for `tuple[x[y]]` string annotation (#17787)
  [red-knot] Implicit instance attributes in generic methods (#17769)
  doc: Add link to `check-typed-exception` from `S110` and `S112` (#17786)
  Fix module name in ASYNC110, 115, and 116 fixes (#17774)
  [red-knot] More informative hover-types for assignments (#17762)
  [syntax-errors] Use consistent message for bad starred expression usage. (#17772)
  red_knot_server: add auto-completion MVP
  Allow passing a virtual environment to `ruff analyze graph` (#17743)
  Bump 0.11.8 (#17766)
  [`flake8-use-pathlib`] Fix `PTH104`false positive when `rename` is passed a file descriptor (#17712)

Author: dcreager

CHANGELOG.md

@@ -1,5 +1,41 @@
 # Changelog
 
+## 0.11.8
+
+### Preview features
+
+- \[`airflow`\] Apply auto fixes to cases where the names have changed in Airflow 3 (`AIR302`, `AIR311`) ([#17553](https://github.com/astral-sh/ruff/pull/17553), [#17570](https://github.com/astral-sh/ruff/pull/17570), [#17571](https://github.com/astral-sh/ruff/pull/17571))
+- \[`airflow`\] Extend `AIR301` rule ([#17598](https://github.com/astral-sh/ruff/pull/17598))
+- \[`airflow`\] Update existing `AIR302` rules with better suggestions ([#17542](https://github.com/astral-sh/ruff/pull/17542))
+- \[`refurb`\] Mark fix as safe for `readlines-in-for` (`FURB129`) ([#17644](https://github.com/astral-sh/ruff/pull/17644))
+- [syntax-errors] `nonlocal` declaration at module level ([#17559](https://github.com/astral-sh/ruff/pull/17559))
+- [syntax-errors] Detect single starred expression assignment `x = *y` ([#17624](https://github.com/astral-sh/ruff/pull/17624))
+
+### Bug fixes
+
+- \[`flake8-pyi`\] Ensure `Literal[None,] | Literal[None,]` is not autofixed to `None | None` (`PYI061`) ([#17659](https://github.com/astral-sh/ruff/pull/17659))
+- \[`flake8-use-pathlib`\] Avoid suggesting `Path.iterdir()` for `os.listdir` with file descriptor (`PTH208`) ([#17715](https://github.com/astral-sh/ruff/pull/17715))
+- \[`flake8-use-pathlib`\] Fix `PTH104` false positive when `rename` is passed a file descriptor ([#17712](https://github.com/astral-sh/ruff/pull/17712))
+- \[`flake8-use-pathlib`\] Fix `PTH116` false positive when `stat` is passed a file descriptor ([#17709](https://github.com/astral-sh/ruff/pull/17709))
+- \[`flake8-use-pathlib`\] Fix `PTH123` false positive when `open` is passed a file descriptor from a function call ([#17705](https://github.com/astral-sh/ruff/pull/17705))
+- \[`pycodestyle`\] Fix duplicated diagnostic in `E712` ([#17651](https://github.com/astral-sh/ruff/pull/17651))
+- \[`pylint`\] Detect `global` declarations in module scope (`PLE0118`) ([#17411](https://github.com/astral-sh/ruff/pull/17411))
+- [syntax-errors] Make `async-comprehension-in-sync-comprehension` more specific ([#17460](https://github.com/astral-sh/ruff/pull/17460))
+
+### Configuration
+
+- Add option to disable `typing_extensions` imports ([#17611](https://github.com/astral-sh/ruff/pull/17611))
+
+### Documentation
+
+- Fix example syntax for the `lint.pydocstyle.ignore-var-parameters` option ([#17740](https://github.com/astral-sh/ruff/pull/17740))
+- Add fix safety sections (`ASYNC116`, `FLY002`, `D200`, `RUF005`, `RUF017`, `RUF027`, `RUF028`, `RUF057`) ([#17497](https://github.com/astral-sh/ruff/pull/17497), [#17496](https://github.com/astral-sh/ruff/pull/17496), [#17502](https://github.com/astral-sh/ruff/pull/17502), [#17484](https://github.com/astral-sh/ruff/pull/17484), [#17480](https://github.com/astral-sh/ruff/pull/17480), [#17485](https://github.com/astral-sh/ruff/pull/17485), [#17722](https://github.com/astral-sh/ruff/pull/17722), [#17483](https://github.com/astral-sh/ruff/pull/17483))
+
+### Other changes
+
+- Add Python 3.14 to configuration options ([#17647](https://github.com/astral-sh/ruff/pull/17647))
+- Make syntax error for unparenthesized except tuples version specific to before 3.14 ([#17660](https://github.com/astral-sh/ruff/pull/17660))
+
 ## 0.11.7
 
 ### Preview features

Cargo.lock

@@ -149,8 +149,8 @@ curl -LsSf https://astral.sh/ruff/install.sh | sh
 powershell -c "irm https://astral.sh/ruff/install.ps1 | iex"
 
 # For a specific version.
-curl -LsSf https://astral.sh/ruff/0.11.7/install.sh | sh
-powershell -c "irm https://astral.sh/ruff/0.11.7/install.ps1 | iex"
+curl -LsSf https://astral.sh/ruff/0.11.8/install.sh | sh
+powershell -c "irm https://astral.sh/ruff/0.11.8/install.ps1 | iex"
 ```
 
 You can also install Ruff via [Homebrew](https://formulae.brew.sh/formula/ruff), [Conda](https://anaconda.org/conda-forge/ruff),
@@ -183,7 +183,7 @@ Ruff can also be used as a [pre-commit](https://pre-commit.com/) hook via [`ruff
 ```yaml
 - repo: https://github.com/astral-sh/ruff-pre-commit
   # Ruff version.
-  rev: v0.11.7
+  rev: v0.11.8
   hooks:
     # Run the linter.
     - id: ruff

README.md

@@ -0,0 +1,39 @@
+use ruff_db::files::File;
+use ruff_db::parsed::parsed_module;
+use ruff_python_ast::visitor::source_order::SourceOrderVisitor;
+use ruff_python_ast::{AnyNodeRef, Identifier};
+use ruff_text_size::TextSize;
+
+use crate::Db;
+
+pub struct Completion {
+    pub label: String,
+}
+
+pub fn completion(db: &dyn Db, file: File, _offset: TextSize) -> Vec<Completion> {
+    let parsed = parsed_module(db.upcast(), file);
+    identifiers(parsed.syntax().into())
+        .into_iter()
+        .map(|label| Completion { label })
+        .collect()
+}
+
+fn identifiers(node: AnyNodeRef) -> Vec<String> {
+    struct Visitor {
+        identifiers: Vec<String>,
+    }
+
+    impl<'a> SourceOrderVisitor<'a> for Visitor {
+        fn visit_identifier(&mut self, id: &'a Identifier) {
+            self.identifiers.push(id.id.as_str().to_string());
+        }
+    }
+
+    let mut visitor = Visitor {
+        identifiers: vec![],
+    };
+    node.visit_source_order(&mut visitor);
+    visitor.identifiers.sort();
+    visitor.identifiers.dedup();
+    visitor.identifiers
+}

crates/red_knot_ide/src/completion.rs

@@ -444,20 +444,141 @@ mod tests {
     }
 
     #[test]
-    fn hover_class_member_declaration() {
+    fn hover_variable_assignment() {
+        let test = cursor_test(
+            r#"
+            value<CURSOR> = 1
+            "#,
+        );
+
+        assert_snapshot!(test.hover(), @r"
+        Literal[1]
+        ---------------------------------------------
+        ```text
+        Literal[1]
+        ```
+        ---------------------------------------------
+        info: lint:hover: Hovered content is
+         --> main.py:2:13
+          |
+        2 |             value = 1
+          |             ^^^^^- Cursor offset
+          |             |
+          |             source
+          |
+        ");
+    }
+
+    #[test]
+    fn hover_augmented_assignment() {
+        let test = cursor_test(
+            r#"
+            value = 1
+            value<CURSOR> += 2
+            "#,
+        );
+
+        // We currently show the *previous* value of the variable (1), not the new one (3).
+        // Showing the new value might be more intuitive for some users, but the actual 'use'
+        // of the `value` symbol here in read-context is `1`. This comment mainly exists to
+        // signal that it might be okay to revisit this in the future and reveal 3 instead.
+        assert_snapshot!(test.hover(), @r"
+        Literal[1]
+        ---------------------------------------------
+        ```text
+        Literal[1]
+        ```
+        ---------------------------------------------
+        info: lint:hover: Hovered content is
+         --> main.py:3:13
+          |
+        2 |             value = 1
+        3 |             value += 2
+          |             ^^^^^- Cursor offset
+          |             |
+          |             source
+          |
+        ");
+    }
+
+    #[test]
+    fn hover_attribute_assignment() {
+        let test = cursor_test(
+            r#"
+            class C:
+                attr: int = 1
+
+            C.attr<CURSOR> = 2
+            "#,
+        );
+
+        assert_snapshot!(test.hover(), @r"
+        Literal[2]
+        ---------------------------------------------
+        ```text
+        Literal[2]
+        ```
+        ---------------------------------------------
+        info: lint:hover: Hovered content is
+         --> main.py:5:13
+          |
+        3 |                 attr: int = 1
+        4 |
+        5 |             C.attr = 2
+          |             ^^^^^^- Cursor offset
+          |             |
+          |             source
+          |
+        ");
+    }
+
+    #[test]
+    fn hover_augmented_attribute_assignment() {
+        let test = cursor_test(
+            r#"
+            class C:
+                attr = 1
+
+            C.attr<CURSOR> += 2
+            "#,
+        );
+
+        // See the comment in the `hover_augmented_assignment` test above. The same
+        // reasoning applies here.
+        assert_snapshot!(test.hover(), @r"
+        Unknown | Literal[1]
+        ---------------------------------------------
+        ```text
+        Unknown | Literal[1]
+        ```
+        ---------------------------------------------
+        info: lint:hover: Hovered content is
+         --> main.py:5:13
+          |
+        3 |                 attr = 1
+        4 |
+        5 |             C.attr += 2
+          |             ^^^^^^- Cursor offset
+          |             |
+          |             source
+          |
+        ");
+    }
+
+    #[test]
+    fn hover_annotated_assignment() {
         let test = cursor_test(
             r#"
         class Foo:
             a<CURSOR>: int
         "#,
         );
 
-        // TODO: This should be int and not `Never`, https://github.com/astral-sh/ruff/issues/17122
         assert_snapshot!(test.hover(), @r"
-        Never
+        int
         ---------------------------------------------
         ```text
-        Never
+        int
         ```
         ---------------------------------------------
         info: lint:hover: Hovered content is
@@ -472,6 +593,64 @@ mod tests {
         ");
     }
 
+    #[test]
+    fn hover_annotated_assignment_with_rhs() {
+        let test = cursor_test(
+            r#"
+        class Foo:
+            a<CURSOR>: int = 1
+        "#,
+        );
+
+        assert_snapshot!(test.hover(), @r"
+        Literal[1]
+        ---------------------------------------------
+        ```text
+        Literal[1]
+        ```
+        ---------------------------------------------
+        info: lint:hover: Hovered content is
+         --> main.py:3:13
+          |
+        2 |         class Foo:
+        3 |             a: int = 1
+          |             ^- Cursor offset
+          |             |
+          |             source
+          |
+        ");
+    }
+
+    #[test]
+    fn hover_annotated_attribute_assignment() {
+        let test = cursor_test(
+            r#"
+        class Foo:
+            def __init__(self, a: int):
+                self.a<CURSOR>: int = a
+        "#,
+        );
+
+        assert_snapshot!(test.hover(), @r"
+        int
+        ---------------------------------------------
+        ```text
+        int
+        ```
+        ---------------------------------------------
+        info: lint:hover: Hovered content is
+         --> main.py:4:17
+          |
+        2 |         class Foo:
+        3 |             def __init__(self, a: int):
+        4 |                 self.a: int = a
+          |                 ^^^^^^- Cursor offset
+          |                 |
+          |                 source
+          |
+        ");
+    }
+
     #[test]
     fn hover_type_narrowing() {
         let test = cursor_test(

crates/red_knot_ide/src/hover.rs

@@ -1,10 +1,12 @@
+mod completion;
 mod db;
 mod find_node;
 mod goto;
 mod hover;
 mod inlay_hints;
 mod markup;
 
+pub use completion::completion;
 pub use db::Db;
 pub use goto::goto_type_definition;
 pub use hover::hover;

crates/red_knot_ide/src/lib.rs

@@ -0,0 +1,9 @@
+# Regression test for an issue that came up while working
+# on https://github.com/astral-sh/ruff/pull/17769
+
+class C:
+    def method[T](self, x: T) -> T:
+        def inner():
+            self.attr = 1
+
+C().attr

crates/red_knot_project/resources/test/corpus/88_regression_generic_method_with_nested_function.py

@@ -0,0 +1 @@
+t: "tuple[list[int]]"

crates/red_knot_project/resources/test/corpus/95_annotation_string_tuple.py

@@ -1950,6 +1950,27 @@ reveal_type(C.a_type)  # revealed: type
 reveal_type(C.a_none)  # revealed: None
 ```
 
+### Generic methods
+
+We also detect implicit instance attributes on methods that are themselves generic. We have an extra
+test for this because generic functions have an extra type-params scope in between the function body
+scope and the outer scope, so we need to make sure that our implementation can still recognize `f`
+as a method of `C` here:
+
+```toml
+[environment]
+python-version = "3.12"
+```
+
+```py
+class C:
+    def f[T](self, t: T) -> T:
+        self.x: int = 1
+        return t
+
+reveal_type(C().x)  # revealed: int
+```
+
 ## Enum classes
 
 Enums are not supported yet; attribute access on an enum class is inferred as `Todo`.