feat: add Range::is_empty() (pubgrub-rs#189)

konstin · web-flow · commit 3549dc50cb8c · 2024-03-12T13:48:43.000Z
We use `Range::is_empty()` for special casing the empty version range in error messages. This mirrors std, which has `is_empty` methods on all of its collections: https://doc.rust-lang.org/nightly/std/?search=is_empty Example usages: https://github.com/astral-sh/uv/blob/8d721830db8ad75b8b7ef38edc0e346696c52e3d/crates/uv-resolver/src/pubgrub/report.rs#L553 https://github.com/astral-sh/uv/blob/8d721830db8ad75b8b7ef38edc0e346696c52e3d/crates/uv-resolver/src/pubgrub/report.rs#L565
diff --git a/src/range.rs b/src/range.rs
@@ -119,6 +119,11 @@ impl<V> Range<V> {
             segments: SmallVec::one((Included(v1.into()), Excluded(v2.into()))),
         }
     }
+
+    /// Whether the set is empty, i.e. it has not ranges
+    pub fn is_empty(&self) -> bool {
+        self.segments.is_empty()
+    }
 }
 
 impl<V: Clone> Range<V> {

Original file line number	Diff line number	Diff line change
`@@ -119,6 +119,11 @@ impl<V> Range<V> {`
`119`	`119`	`segments: SmallVec::one((Included(v1.into()), Excluded(v2.into()))),`
`120`	`120`	`}`
`121`	`121`	`}`
	`122`	`+`
	`123`	`+ /// Whether the set is empty, i.e. it has not ranges`
	`124`	`+ pub fn is_empty(&self) -> bool {`
	`125`	`+ self.segments.is_empty()`
	`126`	`+ }`
`122`	`127`	`}`
`123`	`128`
`124`	`129`	`impl<V: Clone> Range<V> {`