TST: work around pyodide and ninja

Author: mattip

.github/workflows/build_test.yml

@@ -96,7 +96,7 @@ jobs:
         # for add-apt-repository
         sudo apt install software-properties-common -y
         sudo add-apt-repository ppa:deadsnakes/ppa -y
-        sudo apt install python3.9-dev -y
+        sudo apt install python3.9-dev ninja-build -y
         sudo ln -s /usr/bin/python3.9 /usr/bin/pythonx
         pythonx -m pip install --upgrade pip setuptools wheel
         pythonx -m pip install -r test_requirements.txt

.github/workflows/wheels.yml

@@ -192,6 +192,7 @@ jobs:
           # TODO: Don't run test suite, and instead build wheels from sdist
           # Depends on pypa/cibuildwheel#1020
           python -m pip install dist/*.gz
+          pip install ninja
           pip install -r test_requirements.txt
           cd .. # Can't import numpy within numpy src directory
           python -c "import numpy, sys; print(numpy.__version__); sys.exit(numpy.test() is False)"

azure-pipelines.yml

@@ -32,42 +32,6 @@ stages:
       - bash: echo "##vso[task.setvariable variable=start_main;isOutput=true]$RET"
         name: result
 
-- stage: InitialTests
-  condition: and(succeeded(), eq(dependencies.Check.outputs['Skip.result.start_main'], 'true'))
-  dependsOn: Check
-  jobs:
-
-  # Native build is based on gcc flag `-march=native`
-  - job: Linux_baseline_native
-    pool:
-      vmImage: 'ubuntu-20.04'
-    steps:
-    - script: |
-        git submodule update --init
-      displayName: 'Fetch submodules'
-    - script: |
-            if ! `gcc 2>/dev/null`; then
-                sudo apt install gcc
-            fi
-            sudo add-apt-repository ppa:deadsnakes/ppa -y
-            sudo apt install python3.9
-            sudo apt install python3.9-dev
-            sudo apt install python3.9-distutils
-            # python3 has no setuptools, so install one to get us going
-            python3.9 -m pip install --user --upgrade pip 'setuptools<49.2.0'
-            python3.9 -m pip install --user -r test_requirements.txt
-      displayName: 'install python/requirements'
-    - script: |
-            python3.9 runtests.py --show-build-log --cpu-baseline=native --cpu-dispatch=none \
-            --debug-info --mode=full -- -rsx --junitxml=junit/test-results.xml
-      displayName: 'Run native baseline Build / Tests'
-    - task: PublishTestResults@2
-      condition: succeededOrFailed()
-      inputs:
-        testResultsFiles: '**/test-*.xml'
-        failTaskOnFailedTests: true
-        testRunTitle: 'Publish test results for baseline/native'
-
 - stage: ComprehensiveTests
   condition: and(succeeded(), eq(dependencies.Check.outputs['Skip.result.start_main'], 'true'))
   dependsOn: Check
@@ -101,6 +65,7 @@ stages:
         git submodule update --init
       displayName: 'Fetch submodules'
     - script: |
+            # yum does not have a ninja package, so use the PyPI one
             docker run -v $(pwd):/numpy -e CFLAGS="-msse2 -std=c99 -UNDEBUG" \
             -e F77=gfortran-5 -e F90=gfortran-5 quay.io/pypa/manylinux2014_i686 \
             /bin/bash -xc " \
@@ -111,6 +76,7 @@ stages:
             target=\$(python3 tools/openblas_support.py) && \
             cp -r \$target/lib/* /usr/lib && \
             cp \$target/include/* /usr/include && \
+            python3 -m pip install ninja && \
             python3 -m pip install -r test_requirements.txt && \
             echo CFLAGS \$CFLAGS && \
             python3 -m pip install -v . && \
@@ -175,7 +141,7 @@ stages:
     - script: |
         python -m pip install -r test_requirements.txt
         # Don't use doc_requirements.txt since that messes up tests
-        python -m pip install vulture sphinx==4.3.0 numpydoc==1.4.0
+        python -m pip install vulture sphinx==4.3.0 numpydoc==1.4.0 ninja
       displayName: 'Install dependencies; some are optional to avoid test skips'
     - script: /bin/bash -c "! vulture . --min-confidence 100 --exclude doc/,numpy/distutils/ | grep 'unreachable'"
       displayName: 'Check for unreachable code paths in Python modules'

azure-steps-windows.yml

@@ -19,6 +19,7 @@ steps:
     choco install --confirm --no-progress --allow-downgrade rtools --version=4.3.5550
     choco install unzip -y
     choco install -y --checksum 6004DF17818F5A6DBF19CB335CC92702 pkgconfiglite
+    choco install ninja
     echo "##vso[task.setvariable variable=RTOOLS43_HOME]c:\rtools43"
   displayName: 'Install utilities'
 

pyproject.toml

@@ -145,7 +145,12 @@ tracker = "https://github.com/numpy/numpy/issues"
 skip = "cp36-* cp37-* cp-38* pp37-* *-manylinux_i686 *_ppc64le *_s390x *-musllinux_aarch64 *-win32"
 build-verbosity = "3"
 before-build = "bash {project}/tools/wheels/cibw_before_build.sh {project}"
-before-test = "pip install -r {project}/test_requirements.txt"
+# meson has a hard dependency on ninja, and we need meson to build
+# c-extensions in tests. There is a ninja PyPI package used in
+# build_requirements.txt for macOS, windows, linux but it cannot be in
+# test_requirements.txt since pyodide, which uses test_requirements.txt, does
+# not have it.
+before-test = "pip install ninja && pip install -r {project}/test_requirements.txt"
 test-command = "bash {project}/tools/wheels/cibw_test_command.sh {project}"
 
 [tool.cibuildwheel.linux]

tools/travis-test.sh

@@ -80,6 +80,13 @@ setup_base()
 
 run_test()
 {
+  # meson has a hard dependency on ninja, and we need meson to build
+  # c-extensions in tests. There is a hack ninja PyPI package used in
+  # build_requirements.txt for macOS, windows, linux but it cannot be in
+  # test_requirements.txt since pyodide, which uses test_requirements.txt, does
+  # not have it.
+  PYTHONOPTIMIZE="" $PIP install ninja
+
   # Install the test dependencies.
   # Clear PYTHONOPTIMIZE when running `pip install -r test_requirements.txt`
   # because version 2.19 of pycparser (a dependency of one of the packages