feat: make python executable dynamic depending on os

Author: ashish10alex

cmd/format.go

@@ -7,6 +7,7 @@ import (
 	"fmt"
 	"log/slog"
 	"path/filepath"
+	"runtime"
 	"sync"
 
 	"github.com/fatih/color"
@@ -64,6 +65,13 @@ var formatCmd = &cobra.Command{
             slog.Bool("isFile", !fileInfo.IsDir()),
 		)
 
+        // doing this as there seems to be a hassle using python as executable in $PATH in macos
+        pythonExecutable := "python3"
+        if runtime.GOOS == "windows" {
+            pythonExecutable = "python"
+        } else {
+            pythonExecutable = "python3"
+        }
 
 		if fileInfo.IsDir() {
 			fmt.Println("\nDirectory to format: ", green(fileOrDirPath))
@@ -83,7 +91,7 @@ var formatCmd = &cobra.Command{
 				wg.Add(1)
 				go func(i int) {
 					defer wg.Done()
-					formatSqlxFile((*sqlxFiles)[i], inplace, sqlfluffConfigPath, logger)
+					formatSqlxFile((*sqlxFiles)[i], inplace, sqlfluffConfigPath, pythonExecutable, logger)
 				}(i)
 			}
 			wg.Wait()
@@ -94,7 +102,7 @@ var formatCmd = &cobra.Command{
 				fmt.Printf(red("Only .sqlx files are supported for formatting \n"))
 				return
 			}
-			formatSqlxFile(fileOrDirPath, inplace, sqlfluffConfigPath, logger)
+			formatSqlxFile(fileOrDirPath, inplace, sqlfluffConfigPath, pythonExecutable, logger)
 		} else {
 			cmd.Help()
 		}

cmd/utils.go

@@ -48,10 +48,10 @@ func findSqlxFiles(dataformRootDirectory string) *[]string {
 	return nil
 }
 
-func formatSqlCode(sqlxFileMetaData *sqlxFileMetaData, pythonScriptPath string, sqlfluffConfigPath string, logger *slog.Logger) error {
+func formatSqlCode(sqlxFileMetaData *sqlxFileMetaData, pythonScriptPath string, sqlfluffConfigPath string, pythonExecutable string, logger *slog.Logger) error {
 	queryString := *&sqlxFileMetaData.queryString
 
-	cmd := exec.Command("python", pythonScriptPath, string(sqlfluffConfigPath), string(queryString))
+	cmd := exec.Command(pythonExecutable, pythonScriptPath, string(sqlfluffConfigPath), string(queryString))
 
 	var stdout bytes.Buffer
 	var stderr bytes.Buffer
@@ -133,14 +133,14 @@ func writeContentsToFileInPlace(sqlxFileMetaData *sqlxFileMetaData, formattingEr
 	}
 }
 
-func formatSqlxFile(sqlxFilePath string, inplace bool, sqlfluffConfigPath string, logger *slog.Logger) {
+func formatSqlxFile(sqlxFilePath string, inplace bool, sqlfluffConfigPath string, pythonExecutable string, logger *slog.Logger) {
 	sqlxFileMetaData, err := getSqlxFileMetaData(sqlxFilePath)
 
 	if err != nil {
 		fmt.Println("Error finding config blocks:", err)
 	} else {
         pythonScriptPath := filepath.Join(".formatdataform", "sqlfluff_formatter.py")
-		formattingError := formatSqlCode(&sqlxFileMetaData, pythonScriptPath, sqlfluffConfigPath, logger)
+		formattingError := formatSqlCode(&sqlxFileMetaData, pythonScriptPath, sqlfluffConfigPath, pythonExecutable, logger)
 		if inplace {
 			writeContentsToFileInPlace(&sqlxFileMetaData, formattingError)
 		} else {