Tests for dd fallback

Author: ashald

README.md

@@ -21,10 +21,13 @@ go mod tidy
 ```
 
 ## Test
-on ext4/xfs vs ext3
-
 uid/gid - default & custom
 
 mode - default & custom
 
 inspect - should export status fields
+
+# Extra
+if _, err := exec.LookPath("mkfs.xfs"); err != nil {
+		logrus.Fatal("mkfs.xfs is not available, please install xfsprogs to continue")
+	}

tests/test.sh

@@ -12,9 +12,23 @@ oneTimeSetUp() {
 
 setUp() {
     HANDLE=$(mktemp -u)
-    truncate -s "${1:-2GiB}" "${HANDLE}"
-    mkfs.xfs "${HANDLE}" &> /dev/null
-    mount -o nouuid "${HANDLE}" "${DATA_DIR}"
+    truncate -s "${BASE_SIZE:-2G}" "${HANDLE}"
+
+
+    case "${BASE_FS:-xfs}" in
+    xfs)
+        mkfs.xfs "${HANDLE}" &> /dev/null
+        mount -o nouuid "${HANDLE}" "${DATA_DIR}"
+        ;;
+    ext*)
+        mkfs.${BASE_FS} -F "${HANDLE}" &> /dev/null
+        mount "${HANDLE}" "${DATA_DIR}"
+        ;;
+    *)
+        echo "Unsupported BASE fs"
+        exit 1
+        ;;
+    esac
 }
 
 tearDown() {

tests/test_backing_fs.sh

@@ -0,0 +1,36 @@
+#!/usr/bin/env bash
+
+BASE_SIZE="100M"
+BASE_FS="ext3"
+
+testFallbackToDdFromFallocateOnUnsupportedFs() {
+    local error result count
+    # setup
+
+    ## for sparse=false we use fallocate and fallback to dd if fallocate is not supported
+    error=$(docker volume create -d "${DRIVER}" -o fs=xfs -o sparse=false -o size=50MiB 2>&1)
+    result=$?
+
+    ## because we shadow real data dir with our test volume we're sure there shouldn't be any volumes
+    count=$(ls -1 "/var/lib/${DRIVER}/" | grep -v "lost+found" | wc -l)
+
+    assertEquals "0" "${result}"
+    assertEquals "1" "${count}"
+}
+
+testDdFailureScenarioWhenThereIsNotEnoughDiskSpace() {
+    local error result count
+    # setup
+
+    ## attempt creating 2 GiB volume while we have only 1 GiB of space
+    error=$(docker volume create -d "${DRIVER}" -o fs=xfs -o sparse=false -o size=200MiB 2>&1)
+    result=$?
+
+    ## because we shadow real data dir with our test volume we're sure there shouldn't be any volumes
+    count=$(ls -1 "/var/lib/${DRIVER}/" | grep -v "lost+found" | wc -l)
+
+    assertEquals "1" "${result}"
+    assertEquals "0" "${count}"
+}
+
+. test.sh