XFS tests

Author: ashald

README.md

@@ -25,22 +25,12 @@ TODO:
 - check if xfs bug manifests after fallocate
 - check if xfs bug manifests via docker containers
 - check if '-o nouuid' works with ext4 
-- add '-o nouuid'
-- add test that volume can be remounted after adding some data
-
-create sparse  ext4 volume of 1GiB on a 100 MiB disk - success
-create regular ext4 volume of 1GiB on a 100 Mib disk - fail  
-
-create sparse  xfs volume of 1GiB on a 100 MiB disk - success
-create regular xfs volume of 1GiB on a 100 MiB disk - fail
+- add '-o nouuid'  
 
 on ext4/xfs vs ext3
 
-not enough space - data file should be cleaned up
-
 uid/gid - default & custom
 
 mode - default & custom
 
 inspect - should export status fields
-

tests/test_ext4.sh

@@ -2,22 +2,6 @@
 
 FS="ext4"
 
-testRegularVolumeDoesNotReserveDiskSpace() {
-    local volume info allocated_size apparent_size
-    # setup
-    volume=$(docker volume create -d "${DRIVER}" -o fs=${FS} -o sparse=false)
-
-    info=$(ls --block-size=M -ls "/var/lib/${DRIVER}/${volume}.${FS}")
-    allocated_size=$(echo ${info} | awk '{print $1}' | tr -dc '0-9')
-    apparent_size=$(echo ${info} | awk '{print $6}' | tr -dc '0-9')
-
-    # checks
-    assertTrue "Regular ${FS} volume of ${apparent_size} MiB should take less space: ${allocated_size} MiB" "[ ${allocated_size} -lt ${apparent_size} ]"
-
-    # cleanup
-    docker volume rm "${volume}" > /dev/null
-}
-
 testRegularVolumeChecksDiskSpaceBeforeFormatting() {
     local error result count
     # setup
@@ -34,6 +18,22 @@ testRegularVolumeChecksDiskSpaceBeforeFormatting() {
     assertEquals "0" "${count}"
 }
 
+testRegularVolumeDoesNotReserveDiskSpace() {
+    local volume info allocated_size apparent_size
+    # setup
+    volume=$(docker volume create -d "${DRIVER}" -o fs=${FS} -o sparse=false)
+
+    info=$(ls --block-size=M -ls "/var/lib/${DRIVER}/${volume}.${FS}")
+    allocated_size=$(echo ${info} | awk '{print $1}' | tr -dc '0-9')
+    apparent_size=$(echo ${info} | awk '{print $6}' | tr -dc '0-9')
+
+    # checks
+    assertTrue "Regular ${FS} volume of ${apparent_size} MiB should take less space: ${allocated_size} MiB" "[ ${allocated_size} -lt ${apparent_size} ]"
+
+    # cleanup
+    docker volume rm "${volume}" > /dev/null
+}
+
 testSparseVolumeDoesNotCheckAvailableDiskSpace() {
     local volume result info apparent_size
     # setup

tests/test_xfs.sh

@@ -2,31 +2,66 @@
 
 FS="xfs"
 
-testSparseVolumeDoesNotTakeDiskSpace() {
+testRegularVolumeChecksDiskSpaceBeforeFormatting() {
+    local error result count
+    # setup
+
+    ## attempt creating 10 GiB volume while we have only 2 GiB of space
+    error=$(docker volume create -d "${DRIVER}" -o fs=${FS} -o sparse=false -o size=10GiB 2>&1)
+    result=$?
+
+    ## because we shadow real data dir with our test volume we're sure there shouldn't be any volumes
+    count=$(ls -1 "/var/lib/${DRIVER}/" | wc -l)
+
+    # checks
+    assertEquals "1" "${result}"
+    assertEquals "0" "${count}"
+}
+
+testRegularVolumeReservesDiskSpace() {
     local volume info allocated_size apparent_size
     # setup
-    local volume=$(docker volume create -d "${DRIVER}" -o fs=${FS} -o sparse=true)
+    local volume=$(docker volume create -d "${DRIVER}" -o fs=${FS} -o sparse=false)
     local info=$(ls --block-size=M -ls "/var/lib/${DRIVER}/${volume}.${FS}")
     local allocated_size=$(echo ${info} | awk '{print $1}' | tr -dc '0-9')
     local apparent_size=$(echo ${info} | awk '{print $6}' | tr -dc '0-9')
 
     # checks
-    assertTrue "Sparse ${FS} volume of ${apparent_size} MiB should take less space: ${allocated_size} MiB" "[ ${allocated_size} -lt ${apparent_size} ]"
+    assertTrue "Regular ${FS} volume of ${apparent_size} MiB should take at least same space: ${allocated_size} MiB" "[ ${allocated_size} -ge ${apparent_size} ]"
 
     # cleanup
     docker volume rm "${volume}" > /dev/null
 }
 
-testRegularVolumeReservesDiskSpace() {
+testSparseVolumeDoesNotCheckAvailableDiskSpace() {
+    local volume result info apparent_size
+    # setup
+
+    ## attempt creating 10 GiB volume while we have only 2 GiB of space
+    volume=$(docker volume create -d "${DRIVER}" -o fs=${FS} -o sparse=true -o size=10GiB)
+    result=$?
+
+    info=$(ls --block-size=M -ls "/var/lib/${DRIVER}/${volume}.${FS}")
+    apparent_size=$(echo ${info} | awk '{print $6}' | tr -dc '0-9')
+
+    # checks
+    assertEquals "0" "${result}"
+    assertEquals "10240" "${apparent_size}"
+
+    # cleanup
+    docker volume rm "${volume}" > /dev/null
+}
+
+testSparseVolumeDoesNotTakeDiskSpace() {
     local volume info allocated_size apparent_size
     # setup
-    local volume=$(docker volume create -d "${DRIVER}" -o fs=${FS} -o sparse=false)
+    local volume=$(docker volume create -d "${DRIVER}" -o fs=${FS} -o sparse=true)
     local info=$(ls --block-size=M -ls "/var/lib/${DRIVER}/${volume}.${FS}")
     local allocated_size=$(echo ${info} | awk '{print $1}' | tr -dc '0-9')
     local apparent_size=$(echo ${info} | awk '{print $6}' | tr -dc '0-9')
 
     # checks
-    assertTrue "Regular ${FS} volume of ${apparent_size} MiB should take at least same space: ${allocated_size} MiB" "[ ${allocated_size} -ge ${apparent_size} ]"
+    assertTrue "Sparse ${FS} volume of ${apparent_size} MiB should take less space: ${allocated_size} MiB" "[ ${allocated_size} -lt ${apparent_size} ]"
 
     # cleanup
     docker volume rm "${volume}" > /dev/null