Small notification annoyance

[TTorell]

If we are playing an engine, we get notified by a pop-up window about the result of the game when it's finished.
If we press OK and then for instance choose Mode->Engines... the same notification pops up again, we press OK, do something in the Engine dialog and press OK and the same notification reappears for the third time.

There's already a mechanism in the code to prevent this, the doNotNotifyAboutResult boolean, but it's reset to often.
We only have to reset that boolean to false when we have started playing something again, I think.

So I suggest this fix in ModeMenuController stateChanged()

if(mode == GameModel.MODE_PLAY_WHITE || mode == GameModel.MODE_PLAY_BLACK || 
   mode == GameModel.MODE_PLAYOUT_POSITION) {
     gameModel.doNotNotifyAboutResult = false;
 }

instead of just:
gameModel.doNotNotifyAboutResult = false;

(Maybe it should be a set-method instead of setting a member of another class directly, but the code is full of those anyway.)

It seems to fix the problem and not create any new ones.

[TTorell]

My new object oriented suggestion is to check the mode-constants inside a method in GameModel, "isPlayingMode()"
and call that method in places where it could be used in ModeMenuController (three places). It would make it easier to add a new "playing-mode"-constant by just changing inside GameModel, for instance. Your choise.

[TTorell]

OK, I was blind but now I see ;-). It's more complicated than I first thought of course. You need to notify about results in EnterMovesMode too. Haven't we discussed this once before? I managed to get rid of one of the notifications in my new pull request at least. But I admit it's kind of logical that most of them appear when they do.
But I found a strange example :-). If you close the application whith a mate-position on the board, with the mated side to move, no moves played, and restart the application, then the mate notification is the first thing that appears on the screen, click it and it pops up again, click the new notification and now the main-window turns up. I could repeat it in the deb-distribution. I'll try to find the details of this sometime later.

[asdfjkl]

I just checked how Lichess does it on the analysis board. No notification at all, just the "#". Stalemate is not even detected. I think we should remove all notifications except when we are in PlayAsBlack oder PlayAsWhite modes.

For these modes:

• Don't notify user twice about the result
• After showing the result, the game should be finished, so immediatly switch to EnterMovesMode
• If we switch to PlayAs... modes, do not show notifications for the current position

I guess that shold be somehow logical?!

Maybe the PlayAs... modes also need some revisement to be more user-friendly and engaging