smartlog: replace --reverse flag with config opt

Author: e-q

git-branchless-lib/src/core/config.rs

@@ -108,6 +108,13 @@ pub fn get_smartlog_default_revset(repo: &Repo) -> eyre::Result<String> {
         })
 }
 
+/// Whether to reverse the smartlog direction by default
+#[instrument]
+pub fn get_smartlog_reverse(repo: &Repo) -> eyre::Result<bool> {
+    repo.get_readonly_config()?
+        .get_or("branchless.smartlog.reverse", false)
+}
+
 /// Get the default comment character.
 #[instrument]
 pub fn get_comment_char(repo: &Repo) -> eyre::Result<char> {

git-branchless-opts/src/lib.rs

@@ -340,11 +340,6 @@ pub struct SmartlogArgs {
     #[clap(value_parser)]
     pub revset: Option<Revset>,
 
-    /// Print the smartlog in the opposite of the usual order, with the latest
-    /// commits first.
-    #[clap(long)]
-    pub reverse: bool,
-
     /// Don't automatically add HEAD and the main branch to the list of commits
     /// to present. They will still be added if included in the revset.
     #[clap(long)]

git-branchless-smartlog/src/lib.rs

@@ -19,8 +19,8 @@ use std::time::SystemTime;
 use git_branchless_invoke::CommandContext;
 use git_branchless_opts::{Revset, SmartlogArgs};
 use lib::core::config::{
-    get_hint_enabled, get_hint_string, get_smartlog_default_revset, print_hint_suppression_notice,
-    Hint,
+    get_hint_enabled, get_hint_string, get_smartlog_default_revset, get_smartlog_reverse,
+    print_hint_suppression_notice, Hint,
 };
 use lib::core::repo_ext::RepoExt;
 use lib::core::rewrite::find_rewrite_target;
@@ -747,10 +747,6 @@ mod render {
         /// The options to use when resolving the revset.
         pub resolve_revset_options: ResolveRevsetOptions,
 
-        /// Reverse the ordering of items in the smartlog output, list the most
-        /// recent commits first.
-        pub reverse: bool,
-
         /// Normally HEAD and the main branch are included. Set this to exclude them.
         pub exact: bool,
     }
@@ -767,7 +763,6 @@ pub fn smartlog(
         event_id,
         revset,
         resolve_revset_options,
-        reverse,
         exact,
     } = options;
 
@@ -825,6 +820,7 @@ pub fn smartlog(
         exact,
     )?;
 
+    let reverse = get_smartlog_reverse(&repo)?;
     let mut lines = render_graph(
         &effects.reverse_order(reverse),
         &repo,
@@ -914,7 +910,6 @@ pub fn command_main(ctx: CommandContext, args: SmartlogArgs) -> EyreExitOr<()> {
         event_id,
         revset,
         resolve_revset_options,
-        reverse,
         exact,
     } = args;
 
@@ -925,7 +920,6 @@ pub fn command_main(ctx: CommandContext, args: SmartlogArgs) -> EyreExitOr<()> {
             event_id,
             revset,
             resolve_revset_options,
-            reverse,
             exact,
         },
     )

git-branchless-smartlog/tests/test_smartlog.rs

@@ -183,6 +183,7 @@ fn test_merge_commit_reverse_order() -> eyre::Result<()> {
     let git = make_git()?;
 
     git.init_repo()?;
+    git.run(&["config", "branchless.smartlog.reverse", "true"])?;
     git.run(&["checkout", "-b", "test1", "master"])?;
     git.commit_file("test1", 1)?;
     git.run(&["checkout", "-b", "test2and3", "master"])?;
@@ -196,7 +197,7 @@ fn test_merge_commit_reverse_order() -> eyre::Result<()> {
         },
     )?;
 
-    let (stdout, _) = git.branchless("smartlog", &["--reverse"])?;
+    let (stdout, _) = git.branchless("smartlog", &[])?;
     insta::assert_snapshot!(stdout, @r###"
     @ fa4e4e1 (> test2and3) Merge branch 'test1' into test2and3
     |\
@@ -499,7 +500,7 @@ fn test_smartlog_hint_abandoned_except_current_commit() -> eyre::Result<()> {
     Ok(())
 }
 
-/// When --reverse is specified hints still appear at the end of output
+/// When branchless.smartlog.reverse is `true`, hints still appear at the end of output
 #[test]
 fn test_smartlog_hint_abandoned_reverse_order() -> eyre::Result<()> {
     let git = make_git()?;
@@ -508,14 +509,15 @@ fn test_smartlog_hint_abandoned_reverse_order() -> eyre::Result<()> {
         return Ok(());
     }
     git.init_repo()?;
+    git.run(&["config", "branchless.smartlog.reverse", "true"])?;
 
     git.detach_head()?;
     git.commit_file("test1", 1)?;
     git.commit_file("test2", 2)?;
     git.run(&["checkout", "HEAD^"])?;
     git.run(&["commit", "--amend", "-m", "amended test1"])?;
 
-    let (stdout, _) = git.branchless("smartlog", &["--reverse"])?;
+    let (stdout, _) = git.branchless("smartlog", &[])?;
     insta::assert_snapshot!(stdout, @r###"
     o 96d1c37 create test2.txt
     |

git-branchless/tests/test_init.rs

@@ -316,9 +316,9 @@ fn test_main_branch_not_found_error_message() -> eyre::Result<()> {
 
        0: branchless::core::eventlog::from_event_log_db with effects=<Output fancy=false> repo=<Git repository at: "<repo-path>/.git/"> event_log_db=<EventLogDb path=Some("<repo-path>/.git/branchless/db.sqlite3")>
           at some/file/path.rs:123
-       1: git_branchless_smartlog::smartlog with effects=<Output fancy=false> git_run_info=<GitRunInfo path_to_git="<git-executable>" working_directory="<repo-path>" env=not shown> options=SmartlogOptions { event_id: None, revset: None, resolve_revset_options: ResolveRevsetOptions { show_hidden_commits: false }, reverse: false, exact: false }
+       1: git_branchless_smartlog::smartlog with effects=<Output fancy=false> git_run_info=<GitRunInfo path_to_git="<git-executable>" working_directory="<repo-path>" env=not shown> options=SmartlogOptions { event_id: None, revset: None, resolve_revset_options: ResolveRevsetOptions { show_hidden_commits: false }, exact: false }
           at some/file/path.rs:123
-       2: git_branchless_smartlog::command_main with ctx=CommandContext { effects: <Output fancy=false>, git_run_info: <GitRunInfo path_to_git="<git-executable>" working_directory="<repo-path>" env=not shown> } args=SmartlogArgs { event_id: None, revset: None, reverse: false, exact: false, resolve_revset_options: ResolveRevsetOptions { show_hidden_commits: false } }
+       2: git_branchless_smartlog::command_main with ctx=CommandContext { effects: <Output fancy=false>, git_run_info: <GitRunInfo path_to_git="<git-executable>" working_directory="<repo-path>" env=not shown> } args=SmartlogArgs { event_id: None, revset: None, exact: false, resolve_revset_options: ResolveRevsetOptions { show_hidden_commits: false } }
           at some/file/path.rs:123
 
     Suggestion: