Skip to content

Commit d2cc63e

Browse files
committed
Merge pull request opencv#19680 from alalek:cmake_update_python_linters
2 parents 358878c + 625d4fc commit d2cc63e

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

CMakeLists.txt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1000,6 +1000,12 @@ if(COMMAND ocv_pylint_finalize)
10001000
ocv_pylint_add_directory_recurse(${CMAKE_CURRENT_LIST_DIR}/samples/python/tutorial_code)
10011001
ocv_pylint_finalize()
10021002
endif()
1003+
if(TARGET check_pylint)
1004+
message(STATUS "Registered 'check_pylint' target: using ${PYLINT_EXECUTABLE} (ver: ${PYLINT_VERSION}), checks: ${PYLINT_TOTAL_TARGETS}")
1005+
endif()
1006+
if(TARGET check_flake8)
1007+
message(STATUS "Registered 'check_flake8' target: using ${FLAKE8_EXECUTABLE} (ver: ${FLAKE8_VERSION})")
1008+
endif()
10031009

10041010
if(OPENCV_GENERATE_SETUPVARS)
10051011
include(cmake/OpenCVGenSetupVars.cmake)
@@ -1633,12 +1639,6 @@ endif()
16331639

16341640
status("")
16351641
status(" Python (for build):" PYTHON_DEFAULT_AVAILABLE THEN "${PYTHON_DEFAULT_EXECUTABLE}" ELSE NO)
1636-
if(PYLINT_FOUND AND PYLINT_EXECUTABLE)
1637-
status(" Pylint:" PYLINT_FOUND THEN "${PYLINT_EXECUTABLE} (ver: ${PYLINT_VERSION}, checks: ${PYLINT_TOTAL_TARGETS})" ELSE NO)
1638-
endif()
1639-
if(FLAKE8_FOUND AND FLAKE8_EXECUTABLE)
1640-
status(" Flake8:" FLAKE8_FOUND THEN "${FLAKE8_EXECUTABLE} (ver: ${FLAKE8_VERSION})" ELSE NO)
1641-
endif()
16421642

16431643
# ========================== java ==========================
16441644
if(BUILD_JAVA)

cmake/FindPylint.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ if(PYLINT_EXECUTABLE AND NOT DEFINED PYLINT_VERSION)
1616
execute_process(COMMAND ${PYLINT_EXECUTABLE} --version RESULT_VARIABLE _result OUTPUT_VARIABLE PYLINT_VERSION_RAW)
1717
if(NOT _result EQUAL 0)
1818
ocv_clear_vars(PYLINT_EXECUTABLE PYLINT_VERSION)
19-
elseif(PYLINT_VERSION_RAW MATCHES "pylint([^,]*) ([0-9\\.]+[0-9])")
19+
elseif(PYLINT_VERSION_RAW MATCHES "pylint([^,\n]*) ([0-9\\.]+[0-9])")
2020
set(PYLINT_VERSION "${CMAKE_MATCH_2}")
2121
else()
2222
set(PYLINT_VERSION "unknown")

cmake/OpenCVPylint.cmake

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,6 @@ function(ocv_pylint_finalize)
122122

123123
list(LENGTH PYLINT_TARGET_ID __total)
124124
set(PYLINT_TOTAL_TARGETS "${__total}" CACHE INTERNAL "")
125-
message(STATUS "Pylint: registered ${__total} targets. Build 'check_pylint' target to run checks (\"cmake --build . --target check_pylint\" or \"make check_pylint\")")
126125
configure_file("${OpenCV_SOURCE_DIR}/cmake/templates/pylint.cmake.in" "${CMAKE_BINARY_DIR}/pylint.cmake" @ONLY)
127126

128127
add_custom_target(check_pylint

0 commit comments

Comments
 (0)