Merge pull request #36 from artichoke/fixups

Add lints and ensure doctests wrapped in functions are run

Author: lopopolo

src/lib.rs

@@ -15,6 +15,9 @@
 #![deny(missing_docs, intra_doc_link_resolution_failure)]
 #![deny(missing_debug_implementations)]
 #![warn(rust_2018_idioms)]
+#![warn(trivial_casts, trivial_numeric_casts)]
+#![warn(unused_qualifications)]
+#![warn(variant_size_differences)]
 #![forbid(unsafe_code)]
 #![cfg_attr(not(feature = "std"), no_std)]
 
@@ -47,14 +50,15 @@
 //! ```
 //! # use rand_core::{RngCore, SeedableRng};
 //! # use rand_mt::Mt64;
-//! # fn main() -> Result<(), rand_core::Error> {
+//! # fn example() -> Result<(), rand_core::Error> {
 //! // Create the RNG.
 //! let mut rng = Mt64::new(0x1234_567_89ab_cdef_u64);
 //! // start grabbing randomness from rng...
 //! let mut buf = vec![0; 512];
 //! rng.try_fill_bytes(&mut buf)?;
 //! # Ok(())
 //! # }
+//! # example().unwrap()
 //! ```
 //!
 //! Or if you want to use the default (fixed) seeds that are specified in the

src/mt.rs

@@ -9,7 +9,7 @@
 // option. All files in the project carrying such notice may not be copied,
 // modified, or distributed except according to those terms.
 
-use core::cmp;
+use core::cmp::Ordering;
 use core::convert::TryFrom;
 use core::fmt;
 use core::hash;
@@ -54,25 +54,25 @@ pub struct Mt19937GenRand32 {
     state: [Wrapping<u32>; N],
 }
 
-impl cmp::Eq for Mt19937GenRand32 {}
+impl Eq for Mt19937GenRand32 {}
 
-impl cmp::PartialEq for Mt19937GenRand32 {
+impl PartialEq for Mt19937GenRand32 {
     fn eq(&self, other: &Self) -> bool {
         self.state[..] == other.state[..] && self.idx == other.idx
     }
 }
 
-impl cmp::Ord for Mt19937GenRand32 {
-    fn cmp(&self, other: &Self) -> cmp::Ordering {
+impl Ord for Mt19937GenRand32 {
+    fn cmp(&self, other: &Self) -> Ordering {
         match self.state[..].cmp(&other.state[..]) {
-            cmp::Ordering::Equal => self.idx.cmp(&other.idx),
+            Ordering::Equal => self.idx.cmp(&other.idx),
             ordering => ordering,
         }
     }
 }
 
-impl cmp::PartialOrd for Mt19937GenRand32 {
-    fn partial_cmp(&self, other: &Self) -> Option<cmp::Ordering> {
+impl PartialOrd for Mt19937GenRand32 {
+    fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
         Some(self.cmp(other))
     }
 }
@@ -220,7 +220,7 @@ impl RngCore for Mt19937GenRand32 {
     /// ```
     /// # use rand_core::RngCore;
     /// # use rand_mt::Mt19937GenRand32;
-    /// # fn main() -> Result<(), rand_core::Error> {
+    /// # fn example() -> Result<(), rand_core::Error> {
     /// let mut mt = Mt19937GenRand32::new_unseeded();
     /// let mut buf = [0; 32];
     /// mt.try_fill_bytes(&mut buf)?;
@@ -230,6 +230,7 @@ impl RngCore for Mt19937GenRand32 {
     /// assert_ne!([0; 31], buf);
     /// # Ok(())
     /// # }
+    /// # example().unwrap()
     /// ```
     #[inline]
     fn try_fill_bytes(&mut self, dest: &mut [u8]) -> Result<(), rand_core::Error> {

src/mt64.rs

@@ -9,7 +9,7 @@
 // option. All files in the project carrying such notice may not be copied,
 // modified, or distributed except according to those terms.
 
-use core::cmp;
+use core::cmp::Ordering;
 use core::convert::TryFrom;
 use core::fmt;
 use core::hash;
@@ -51,25 +51,25 @@ pub struct Mt19937GenRand64 {
     state: [Wrapping<u64>; NN],
 }
 
-impl cmp::Eq for Mt19937GenRand64 {}
+impl Eq for Mt19937GenRand64 {}
 
-impl cmp::PartialEq for Mt19937GenRand64 {
+impl PartialEq for Mt19937GenRand64 {
     fn eq(&self, other: &Self) -> bool {
         self.state[..] == other.state[..] && self.idx == other.idx
     }
 }
 
-impl cmp::Ord for Mt19937GenRand64 {
-    fn cmp(&self, other: &Self) -> cmp::Ordering {
+impl Ord for Mt19937GenRand64 {
+    fn cmp(&self, other: &Self) -> Ordering {
         match self.state[..].cmp(&other.state[..]) {
-            cmp::Ordering::Equal => self.idx.cmp(&other.idx),
+            Ordering::Equal => self.idx.cmp(&other.idx),
             ordering => ordering,
         }
     }
 }
 
-impl cmp::PartialOrd for Mt19937GenRand64 {
-    fn partial_cmp(&self, other: &Self) -> Option<cmp::Ordering> {
+impl PartialOrd for Mt19937GenRand64 {
+    fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
         Some(self.cmp(other))
     }
 }
@@ -216,7 +216,7 @@ impl RngCore for Mt19937GenRand64 {
     /// ```
     /// # use rand_core::RngCore;
     /// # use rand_mt::Mt19937GenRand64;
-    /// # fn main() -> Result<(), rand_core::Error> {
+    /// # fn example() -> Result<(), rand_core::Error> {
     /// let mut mt = Mt19937GenRand64::new_unseeded();
     /// let mut buf = [0; 32];
     /// mt.try_fill_bytes(&mut buf)?;
@@ -226,6 +226,7 @@ impl RngCore for Mt19937GenRand64 {
     /// assert_ne!([0; 31], buf);
     /// # Ok(())
     /// # }
+    /// # example().unwrap()
     /// ```
     #[inline]
     fn try_fill_bytes(&mut self, dest: &mut [u8]) -> Result<(), rand_core::Error> {