Skip to content

Commit 27e0c1d

Browse files
neobrainNeo Zhang
authored andcommitted
vulkan : initialize vk_buffer_struct members to VK_NULL_HANDLE (ggml/893)
This prevents invalid frees when destroying a partially initialized vk_buffer_struct. For example, this could happen in ggml_vk_create_buffer when running out of device memory. Co-authored-by: Tony Wasserka <neobrain@users.noreply.github.com>
1 parent 2a6acc6 commit 27e0c1d

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

ggml/src/ggml-vulkan.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -236,8 +236,8 @@ struct vk_device_struct {
236236
};
237237

238238
struct vk_buffer_struct {
239-
vk::Buffer buffer;
240-
vk::DeviceMemory device_memory;
239+
vk::Buffer buffer = VK_NULL_HANDLE;
240+
vk::DeviceMemory device_memory = VK_NULL_HANDLE;
241241
vk::MemoryPropertyFlags memory_property_flags;
242242
void * ptr;
243243
size_t size = 0;

0 commit comments

Comments
 (0)