[bug]: In games with 3+ player ships, if one player ship is destroyed, then opening console select can switch which ship is selected

[quaris628]

What version of Artemis Cosmos?

v1.2.x

What happened?

For example,

1. Client A is ready on ship 1 Artemis
2. Client B is ready on ship 2 Intrepid
3. Client C is ready on ship 3 Aegis
4. The game starts
5. Ship 1 Artemis dies
6. On Client B, manually open console selection
   Expected: Client B still has ship 2 Intrepid selected
   What happens: Client B has ship 3 Aegis selected

After ship 1 Artemis dies, client A automatically goes to the console selection screen with ship 2 Intrepid selected (which I think makes sense), and if Client C manually opens console selection then it will have ship 3 Aegis selected (as expected).

Artemis.Cosmos.destroying.ship.then.console.selection.switches.ship.mp4

Other details what mission, setup, etc.

Vanilla legendary missions

[quaris628]

This will need to be fixed prior to console lockouts being added (#35), otherwise if this situation happens then client B and client C could have the same station selected

[quaris628]

I'm pretty sure the cause is that the destroyed ship is popped from the list of player ships (PLAYER_LIST), but each client's index for what ship they have selected (client_selected_index) is only ever clamped to the valid range when opening console select. That index should be shifted when the ship is popped from the player ship list, but it isn't.

In common_console_select,mast:

# Clamp selected index
client_selected_index = min(PLAYER_COUNT-1, client_selected_index )

on signal player_ship_destroyed:
    await delay_app(0)
    jump select_console_clear_ship

========== select_console_clear_ship
    client_selected_index = 0
    jump  select_console

Note there's no shifting of client_selected_index.
(Evidently player_ship_destroyed only runs for each client whose selected player ship is destroyed, since client B couldn't have had ship 3 Aegis selected if its client_selected_index was set to 0)