Polishing (#65)

Some reduction of compile warnings and a little extra documentation to help people building from source.

Author: adriaandegroot

INSTALL

@@ -14,7 +14,10 @@ Runtime dependencies are:
  * p11-kit >= 0.22.1 for PKCS #11 URI handling
  * libdb >= 4.0 for key->value lookup with BerkeleyDB transactions/replication
  * libtasn1 for parsing of BER and DER data structures
- * NOT-YET: libldns for DNS lookups
+ * libldns for DNS lookups
+ * libunbound for more DNS lookups
+ * Quick-DER >= 1.2.3 for DER manipulation
+ * libkrb5 for Kerberos support
  * NOT-YET: libldap for LDAP lookups
  * NOT-YET: libmemcached for caching of intermediate results
  * NOT-YET: libradius to do additional authn / authz [/acct]
@@ -27,6 +30,16 @@ these dependencies when only a bit is kwown to be required.  That's the
 sort of maturity that this project has not reached yet.
 
 
+Build Packages
+--------------
+
+As a **sugestion** only, here are packages you should have installed
+before trying to build TLSPOOL.
+
+ - Debian
+   - libdb-dev libldns-dev libunbound-dev libkrb5-dev
+   - libgnutls-dev (you'll need one with DANE support)
+
 First-time build
 ----------------
 

src/validate.c

@@ -37,7 +37,7 @@ static int valexp_char_bitnum [128];
 typedef uint32_t valexpreqs_t;
 
 #define VALEXP_CHARBIT(c)  (valexp_char_bitnum [(c)])
-#define VALEXP_CHARKNOWN(c) (((c) >= 0) && ((c) < 128) && (VALEXP_CHARBIT((c)) >= 0))
+#define VALEXP_CHARKNOWN(c) (((c) >= 0) && ((c) <= 127) && (VALEXP_CHARBIT((c)) >= 0))
 #define VALEXP_OPERAND(c) (((c) == '0') || ((c) == '1') || (VALEXP_CHARKNOWN((c))))
 #define VALEXP_SETBIT(b,w)   ((w) |=   (1 << (b)))
 #define VALEXP_RESETBIT(b,w) ((w) &= ~ (1 << (b)))

tool/get_disclose.c

@@ -174,7 +174,7 @@ int main (int argc, char *argv []) {
 	k_selector.size = printable_len;
 	nomore = crs->get (crs, &k_selector, &k_localid, DB_SET);
 	while (nomore == 0) {
-		printf (" - %.*s\n", k_localid.size, k_localid.data);
+		printf (" - %.*s\n", k_localid.size, (const char *)k_localid.data);
 		nomore = crs->get (crs, &k_selector, &k_localid, DB_NEXT_DUP);
 	}
 	crs->close (crs);

tool/set_disclose.c

@@ -178,7 +178,7 @@ int main (int argc, char *argv []) {
 	nomore = crs->get (crs, &k_selector, &e_value, DB_SET);
 	while (nomore == 0) {
 		printf ("Removing local identity %.*s\n",
-				e_value.size, e_value.data);
+				e_value.size, (const char *)e_value.data);
 		if (crs->del (crs, 0) != 0) {
 			fprintf (stderr, "Failed to delete record\n");
 			crs->close (crs);
@@ -198,7 +198,7 @@ int main (int argc, char *argv []) {
 		k_localid.data = argv [argi];
 		k_localid.size = strlen (argv [argi]);
 		printf ("Adding local identity %.*s\n",
-				k_localid.size, k_localid.data);
+				k_localid.size, (const char *)k_localid.data);
 		if (dbh_disc->put (dbh_disc, txn, &k_selector, &k_localid, 0) != 0) {
 			fprintf (stderr, "Failed to write record\n");
 			crs->close (crs);