Fix RdKafka\KafkaConsumer::getMetadata() signature (#522)

Fixes #521

Author: arnaud-lb

kafka_consumer.stub.php

@@ -46,7 +46,7 @@ public function getSubscription(): array {}
     public function unsubscribe(): void {}
 
     /** @tentative-return-type */
-    public function getMetadata(bool $all_topics, Topic $only_topic, int $timeout_ms): Metadata {}
+    public function getMetadata(bool $all_topics, ?Topic $only_topic, int $timeout_ms): Metadata {}
 
     /** @tentative-return-type */
     public function newTopic(string $topic_name, ?TopicConf $topic_conf = null): KafkaConsumerTopic {}

kafka_consumer_arginfo.h

@@ -1,5 +1,5 @@
 /* This is a generated file, edit the .stub.php file instead.
- * Stub hash: aee362c9762bd72d620b36f1e5686d96e09b9cac */
+ * Stub hash: 47e9238c79f5508833423d31a2e09041754dbffb */
 
 ZEND_BEGIN_ARG_INFO_EX(arginfo_class_RdKafka_KafkaConsumer___construct, 0, 0, 1)
 	ZEND_ARG_OBJ_INFO(0, conf, RdKafka\\Conf, 0)
@@ -35,7 +35,7 @@ ZEND_END_ARG_INFO()
 
 ZEND_BEGIN_ARG_WITH_TENTATIVE_RETURN_OBJ_INFO_EX(arginfo_class_RdKafka_KafkaConsumer_getMetadata, 0, 3, RdKafka\\Metadata, 0)
 	ZEND_ARG_TYPE_INFO(0, all_topics, _IS_BOOL, 0)
-	ZEND_ARG_OBJ_INFO(0, only_topic, RdKafka\\Topic, 0)
+	ZEND_ARG_OBJ_INFO(0, only_topic, RdKafka\\Topic, 1)
 	ZEND_ARG_TYPE_INFO(0, timeout_ms, IS_LONG, 0)
 ZEND_END_ARG_INFO()
 

kafka_consumer_legacy_arginfo.h

@@ -1,5 +1,5 @@
 /* This is a generated file, edit the .stub.php file instead.
- * Stub hash: aee362c9762bd72d620b36f1e5686d96e09b9cac */
+ * Stub hash: 47e9238c79f5508833423d31a2e09041754dbffb */
 
 ZEND_BEGIN_ARG_INFO_EX(arginfo_class_RdKafka_KafkaConsumer___construct, 0, 0, 1)
 	ZEND_ARG_INFO(0, conf)

tests/bug521.phpt

@@ -0,0 +1,21 @@
+--TEST--
+Bug #521
+--SKIPIF--
+<?php version_compare(PHP_VERSION, "8.1") < 0 && die("skip PHP < 8.1"); ?>
+--FILE--
+<?php
+
+$reflection = new ReflectionMethod(RdKafka\KafkaConsumer::class, 'getMetadata');
+
+foreach ($reflection->getParameters() as $reflectionParam) {
+    printf(
+        "%s%s%s\n",
+        (string) $reflectionParam->getType(),
+        $reflectionParam->getType() !== null ? ' ' : '',
+        $reflectionParam->getName(),
+    );
+}
+--EXPECT--
+bool all_topics
+?RdKafka\Topic only_topic
+int timeout_ms