Skip to content

Commit 4df786b

Browse files
maksleventalgithub-actions[bot]
authored andcommitted
Automerge: [mlir] remove dangling builders from td (#147619)
These are "dangling" builders (decls are emitted but there are no defns anywhere).
2 parents aa8ca71 + 1770e9b commit 4df786b

File tree

7 files changed

+1
-73
lines changed

7 files changed

+1
-73
lines changed

flang/include/flang/Optimizer/Dialect/FIROps.td

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3624,12 +3624,6 @@ def fir_LocalitySpecifierOp : fir_Op<"local", [IsolatedFromAbove]> {
36243624
attr-dict
36253625
}];
36263626

3627-
let builders = [
3628-
OpBuilder<(ins CArg<"mlir::TypeRange">:$result,
3629-
CArg<"mlir::StringAttr">:$sym_name,
3630-
CArg<"mlir::TypeAttr">:$type)>
3631-
];
3632-
36333627
let extraClassDeclaration = [{
36343628
mlir::BlockArgument getInitMoldArg() {
36353629
auto &region = getInitRegion();

mlir/include/mlir/Dialect/Linalg/TransformOps/LinalgTransformOps.td

Lines changed: 0 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -582,9 +582,6 @@ def LinalgCopyToMemrefOp :
582582
let assemblyFormat = "$target attr-dict `:` "
583583
"functional-type(operands, results) ";
584584

585-
let builders = [
586-
OpBuilder<(ins "Value":$target)>,
587-
];
588585
let extraClassDeclaration = [{
589586
::mlir::DiagnosedSilenceableFailure applyToOne(
590587
::mlir::transform::TransformRewriter &rewriter,
@@ -997,13 +994,6 @@ def PackGreedilyOp : Op<Transform_Dialect, "structured.pack_greedily", [
997994
[DenseArrayCount<3>]>:$matmul_inner_dims_order);
998995
let results = (outs TransformHandleTypeInterface:$packed_op);
999996

1000-
let builders = [
1001-
OpBuilder<(ins "Value":$target,
1002-
"ArrayRef<OpFoldResult>":$mixedMatmulPackedSizes,
1003-
"ArrayRef<int64_t>":$matmulPaddededSizesNextMultipleOf,
1004-
CArg<"ArrayRef<int64_t>", "{}">:$matmulDimsInnerDimsOrder)>
1005-
];
1006-
1007997
let assemblyFormat = [{
1008998
$target
1009999
oilist(
@@ -2509,10 +2499,6 @@ def HoistRedundantVectorTransfersOp :
25092499

25102500
let assemblyFormat = "$target attr-dict `:` functional-type(operands, results) ";
25112501

2512-
let builders = [
2513-
OpBuilder<(ins "Value":$target,
2514-
CArg<"bool", "false">:$verify_non_zero_trip)>,
2515-
];
25162502
let extraClassDeclaration = [{
25172503
::mlir::DiagnosedSilenceableFailure applyToOne(
25182504
::mlir::transform::TransformRewriter &rewriter,
@@ -2546,9 +2532,6 @@ def HoistRedundantVectorBroadcastsOp :
25462532

25472533
let assemblyFormat = "$target attr-dict `:` functional-type(operands, results) ";
25482534

2549-
let builders = [
2550-
OpBuilder<(ins "Value":$target)>,
2551-
];
25522535
let extraClassDeclaration = [{
25532536
::mlir::DiagnosedSilenceableFailure applyToOne(
25542537
::mlir::transform::TransformRewriter &rewriter,
@@ -2623,10 +2606,6 @@ def ConvertConv2DToImg2ColOp : Op<Transform_Dialect,
26232606
let assemblyFormat =
26242607
"$target attr-dict `:` functional-type($target, results)";
26252608

2626-
let builders = [
2627-
OpBuilder<(ins "Value":$target)>
2628-
];
2629-
26302609
let extraClassDeclaration = [{
26312610
::mlir::DiagnosedSilenceableFailure applyToOne(
26322611
::mlir::transform::TransformRewriter &rewriter,
@@ -2666,10 +2645,6 @@ def FlattenElementwiseLinalgOp : Op<Transform_Dialect,
26662645
let assemblyFormat =
26672646
"$target attr-dict `:` functional-type($target, results)";
26682647

2669-
let builders = [
2670-
OpBuilder<(ins "Value":$target)>
2671-
];
2672-
26732648
let extraClassDeclaration = [{
26742649
::mlir::DiagnosedSilenceableFailure applyToOne(
26752650
::mlir::transform::TransformRewriter &rewriter,
@@ -2715,10 +2690,6 @@ def TransposeConv2DOp : Op<Transform_Dialect,
27152690
let assemblyFormat =
27162691
"$target attr-dict `:` functional-type($target, results)";
27172692

2718-
let builders = [
2719-
OpBuilder<(ins "Value":$target)>
2720-
];
2721-
27222693
let extraClassDeclaration = [{
27232694
::mlir::DiagnosedSilenceableFailure applyToOne(
27242695
::mlir::transform::TransformRewriter &rewriter,
@@ -2761,10 +2732,6 @@ def TransposeMatmulOp : Op<Transform_Dialect,
27612732
attr-dict `:` functional-type($target, results)
27622733
}];
27632734

2764-
let builders = [
2765-
OpBuilder<(ins "Value":$target)>
2766-
];
2767-
27682735
let extraClassDeclaration = [{
27692736
::mlir::DiagnosedSilenceableFailure applyToOne(
27702737
::mlir::transform::TransformRewriter &rewriter,
@@ -2801,9 +2768,6 @@ def InsertSliceToCopyOp :
28012768

28022769
let assemblyFormat = "$target attr-dict `:` functional-type(operands, results) ";
28032770

2804-
let builders = [
2805-
OpBuilder<(ins "Value":$target)>,
2806-
];
28072771
let extraClassDeclaration = [{
28082772
::mlir::DiagnosedSilenceableFailure applyToOne(
28092773
::mlir::transform::TransformRewriter &rewriter,
@@ -2859,9 +2823,6 @@ def MapCopyToThreadsOp :
28592823
`:` functional-type(operands, results)
28602824
}];
28612825

2862-
let builders = [
2863-
OpBuilder<(ins "Value":$target)>,
2864-
];
28652826
let extraClassDeclaration = [{
28662827
::mlir::DiagnosedSilenceableFailure applyToOne(
28672828
::mlir::transform::TransformRewriter &rewriter,
@@ -2910,10 +2871,6 @@ def WinogradConv2DOp : Op<Transform_Dialect,
29102871
let assemblyFormat =
29112872
"$target attr-dict `:` functional-type($target, results)";
29122873

2913-
let builders = [
2914-
OpBuilder<(ins "Value":$target)>
2915-
];
2916-
29172874
let extraClassDeclaration = [{
29182875
::mlir::DiagnosedSilenceableFailure applyToOne(
29192876
::mlir::transform::TransformRewriter &rewriter,
@@ -2947,10 +2904,6 @@ def DecomposeWinogradOp : Op<Transform_Dialect,
29472904
let assemblyFormat =
29482905
"$target attr-dict `:` functional-type($target, results)";
29492906

2950-
let builders = [
2951-
OpBuilder<(ins "Value":$target)>
2952-
];
2953-
29542907
let extraClassDeclaration = [{
29552908
::mlir::DiagnosedSilenceableFailure applyToOne(
29562909
::mlir::transform::TransformRewriter &rewriter,

mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1751,10 +1751,6 @@ def DeclareMapperInfoOp : OpenMP_Op<"declare_mapper.info", [
17511751
parent DeclareMapperOp.
17521752
}] # clausesDescription;
17531753

1754-
let builders = [
1755-
OpBuilder<(ins CArg<"const DeclareMapperInfoOperands &">:$clauses)>
1756-
];
1757-
17581754
let extraClassDeclaration = [{
17591755
// Override BlockArgOpenMPOpInterface method because `map` clauses have no
17601756
// associated entry block arguments in this operation.

mlir/include/mlir/Dialect/Ptr/IR/PtrOps.td

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -171,9 +171,6 @@ def Ptr_TypeOffsetOp : Pointer_Op<"type_offset", [Pure]> {
171171

172172
let arguments = (ins TypeAttr:$elementType);
173173
let results = (outs AnySignlessIntegerOrIndex:$result);
174-
let builders = [
175-
OpBuilder<(ins "Type":$elementType)>
176-
];
177174
let assemblyFormat = [{
178175
$elementType attr-dict `:` type($result)
179176
}];

mlir/include/mlir/Dialect/SMT/IR/SMTIntOps.td

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -52,12 +52,6 @@ class VariadicIntOp<string mnemonic> : SMTIntOp<mnemonic, [Pure, Commutative]> {
5252
let arguments = (ins Variadic<IntType>:$inputs);
5353
let results = (outs IntType:$result);
5454
let assemblyFormat = "$inputs attr-dict";
55-
56-
let builders = [
57-
OpBuilder<(ins "mlir::ValueRange":$inputs), [{
58-
build($_builder, $_state, $_builder.getType<smt::IntType>(), inputs);
59-
}]>,
60-
];
6155
}
6256

6357
class BinaryIntOp<string mnemonic> : SMTIntOp<mnemonic, [Pure]> {

mlir/include/mlir/Dialect/Vector/IR/VectorOps.td

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3011,12 +3011,7 @@ def Vector_ScanOp :
30113011
vector<4x8x16x32xf32>, vector<4x16x32xf32>
30123012
```
30133013
}];
3014-
let builders = [
3015-
OpBuilder<(ins "Value":$source, "Value":$initial_value,
3016-
"CombiningKind":$kind,
3017-
CArg<"int64_t", "0">:$reduction_dim,
3018-
CArg<"bool", "true">:$inclusive)>
3019-
];
3014+
30203015
let extraClassDeclaration = [{
30213016
VectorType getSourceType() {
30223017
return ::llvm::cast<VectorType>(getSource().getType());

mlir/test/lib/Dialect/Test/TestOps.td

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1192,7 +1192,6 @@ def OpFuncRef : TEST_Op<"op_funcref"> {
11921192
let description = [{
11931193
The "test.op_funcref" is a test op with a reference to a function symbol.
11941194
}];
1195-
let builders = [OpBuilder<(ins "::mlir::func::FuncOp":$function)>];
11961195
}
11971196

11981197
// Pattern add the argument plus a increasing static number hidden in

0 commit comments

Comments
 (0)