fix(serialize): Allow serialization of unsized types within Rc, Arc, and Cow #975
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR relaxes the implicit
Sized
bound on theCanonicalSerialize
andCanonicalDeserialize
blanket implementations forRc<T>
,Arc<T>
, andCow<'_, T>
.Previously, these implementations required
T: Sized
, which prevented serialization/deserialization of types likeCow<'a, [U]>
even whenU
implemented the necessary traits. This change adds the?Sized
bound toT
in the relevantimpl
blocks withinserialize/src/impls.rs
, allowing these types to be used.closes: #973
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
?Sized
cases (e.g.,Cow<'a, [T]>
) should be added.Pending
section inCHANGELOG.md
- Note: A changelog entry needs to be added.Files changed
in the GitHub PR explorer - Note: Please double-check the changes inserialize/src/impls.rs
.