Skip to content

Containers.start response handling #9

@setiseta

Description

@setiseta

Hello,

thanks for the lib.
i think i found something not working as expected.
if i use the client.containers().start(container.Id); I'm getting a error with status code 204.
As of the docker documentation this is the code for success.
204 no error
304 container already started/stopped

i think they should be added in
harbor-master/lib/endpoints/containers.js
Line: 233
Line: 253
And on line 273 only the code 204 cause ther is no code 304 on restart.

hopefully i'm not wrong.
should i open a PR?

there is a PR#4 with only the code 204 but on more files. maybe this should merged first, and then add 304 to start and stop function?

Best regards

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions