Follow up on "Example fails with minikube" issue

[EricBoix]

This is a follow up of issue #58 ("Example fails with minikube")

If we look at the code refered by @flaviuvadan that is k8s_sa.py on line 39 (which is pretty dated code but I wasn't able to find any recent equivalent), it assumes that at least a secret will be encoutered with the expression

v1.read_namespaced_service_account(self.service_account, self.namespace).secrets[0]...

But (by default) if you

• start a minikube server (minikube start)
• install and start an argo server (e.g. with kubectl apply -f https://raw.githubusercontent.com/argoproj/argo-workflows/master/manifests/quick-start-postgres.yaml)
• possibly define some argo namespace (e.g. with kubectl create ns argo)
• expose the argo-server (e.g. with kubectl -n argo port-forward service/argo-server 2746:2746 &)
• eventually explore the available service accounts through the minikube UI (with minikube dashboard)

then neither of the available service accounts (argo-server and argo) have secrets defined. Which makes the k8s_sa.py fail when trying to retrieve the secret_name.

Is then have two questions

1. Is there some Hera on minikube installation guide (even sketchy) or examples documenting how to install argo + Hera on minikube and then get the tutorial examples to run ?
2. If the ArgoServer access is not restricted (just like the one obtained after a clean install on minikube), do we still need to define the GlobalConfig.token value ? (refer here for a self-made documentation on this)

[elliotgunton]

Hi @EricBoix - Hera runs tests on a k3d K8s cluster in CI (minikube also worked when I was testing both out in #887). We have a contributors guide that explains how to use the make targets, which are in

hera/Makefile

Lines 135 to 173 in a787965

	.PHONY: install-k3d
	install-k3d: ## Install k3d client
	curl -s https://raw.githubusercontent.com/k3d-io/k3d/main/install.sh | bash
	.PHONY: install-argo
	install-argo: ## Install argo client
	# Download the binary
	curl -sLO https://github.com/argoproj/argo-workflows/releases/download/v$(ARGO_WORKFLOWS_VERSION)/argo-linux-amd64.gz
	# Unzip
	gunzip argo-linux-amd64.gz
	# Make binary executable
	chmod +x argo-linux-amd64
	# Move binary to path
	sudo mv ./argo-linux-amd64 /usr/local/bin/argo
	# Test installation
	argo version
	.PHONY: run-argo
	run-argo: ## Start the argo server
	k3d cluster list | grep test-cluster || k3d cluster create test-cluster
	k3d kubeconfig merge test-cluster --kubeconfig-switch-context
	kubectl get namespace argo || kubectl create namespace argo
	kubectl apply -n argo -f https://github.com/argoproj/argo-workflows/releases/download/v$(ARGO_WORKFLOWS_VERSION)/install.yaml
	kubectl patch deployment argo-server --namespace argo --type='json' -p='[{"op": "replace", "path": "/spec/template/spec/containers/0/args", "value": ["server", "--auth-mode=server"]}]'
	kubectl create rolebinding default-admin --clusterrole=admin --serviceaccount=argo:default --namespace=argo
	kubectl rollout status -n argo deployment/argo-server --timeout=120s --watch=true
	.PHONY: stop-argo
	stop-argo: ## Stop the argo server
	k3d cluster stop test-cluster
	.PHONY: test-on-cluster
	test-on-cluster: ## Run workflow tests (requires local argo cluster)
	@(kubectl -n argo port-forward deployment/argo-server 2746:2746 &)
	@poetry run python -m pytest tests/submissions -m on_cluster

That might help you get set up?

The token is then not needed, see the example submission here.