Skip to content
This repository was archived by the owner on Oct 19, 2024. It is now read-only.

Commit 4f54a6d

Browse files
committed
fix: repo.GetAppDetails().Helm.GetParameterValueByName not get helm.values
1 parent ebecda7 commit 4f54a6d

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

shared/argocd/service.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,9 @@ func (svc *argoCDService) GetAppDetails(ctx context.Context, appSource *v1alpha1
123123
var has *shared.HelmAppSpec
124124
if appDetail.Helm != nil {
125125
paramsMap := map[string]*v1alpha1.HelmParameter{}
126+
for _, param := range appDetail.Helm.Parameters {
127+
paramsMap[param.Name] = param
128+
}
126129
if appSource.Helm.Parameters != nil {
127130
for _, overrideParam := range appSource.Helm.Parameters {
128131
paramsMap[overrideParam.Name] = &v1alpha1.HelmParameter{
@@ -133,9 +136,6 @@ func (svc *argoCDService) GetAppDetails(ctx context.Context, appSource *v1alpha1
133136
}
134137
}
135138
if appSource.Helm.Values != "" {
136-
for _, param := range appDetail.Helm.Parameters {
137-
paramsMap[param.Name] = param
138-
}
139139
valuesParams, err := GetHelmParametersByValues(appSource.Helm.Values)
140140
if err != nil {
141141
return nil, err

0 commit comments

Comments
 (0)