Simplify file discovery code in markdown:check-links task

Since projects often contain many Markdown files and new files may be added or the paths of the existing files changed
frequently, the best approach for validating Markdown files is to search the project file tree recursively for all
Markdown files, with exclusions configured for the paths of any externally maintained files.

The `markdown:check-links` task uses the markdown-link-check tool. This tool does not have a capability for discovering
Markdown files so it is necessary to use the `find` command to discover the files, then pass their paths to the
markdown-link-check tool.

Previously the discovery code used `find` to generate an array of paths, which was iterated over passed individually to
markdown-link-check in a `for` loop. The `for` loop is unnecessary because `find` has an `-exec` flag that can be used
to execute commands using the discovered paths. Although the syntax and behavior of this flag is unintuitive, these
disadvantages that come from its use are outweighed by the benefits of the significant amount of code that can be
replaced by it. Since the `-exec`/`-execdir` flags are already in use in the assets and project infrastructure, the
maintainer will be forced to work with them regardless.

Author: per1234

Taskfile.yml

@@ -638,50 +638,39 @@ tasks:
             echo "Please install: https://github.com/tcort/markdown-link-check#readme"
             exit 1
           fi
-          # Default behavior of the task on Windows is to exit the task when the first broken link causes a non-zero
-          # exit status, but it's better to check all links before exiting.
-          set +o errexit
-          STATUS=0
           # Using -regex instead of -name to avoid Task's behavior of globbing even when quoted on Windows
           # The odd method for escaping . in the regex is required for windows compatibility because mvdan.cc/sh gives
           # \ characters special treatment on Windows in an attempt to support them as path separators.
-          for file in $(
-            find . \
-              -type d -name '.git' -prune -o \
-              -type d -name '.licenses' -prune -o \
-              -type d -name '__pycache__' -prune -o \
-              -type d -name 'node_modules' -prune -o \
-              -path './{{.CLANG_FORMAT_GOLDEN_TEST_DATA_FOLDER}}/samples' -prune -o \
-              -path './{{.CLANG_FORMAT_INPUT_TEST_DATA_FOLDER}}/samples' -prune -o \
-              -regex ".*[.]md" -print
-          ); do
-            markdown-link-check \
-              --quiet \
-              --config "./.markdown-link-check.json" \
-              "$file"
-            STATUS=$(( $STATUS + $? ))
-          done
-          exit $STATUS
-        else
-          npx --package=markdown-link-check --call='
-            STATUS=0
-            for file in $(
-              find . \
-                -type d -name '.git' -prune -o \
-                -type d -name '.licenses' -prune -o \
-                -type d -name '__pycache__' -prune -o \
-                -type d -name 'node_modules' -prune -o \
-                -path './{{.CLANG_FORMAT_GOLDEN_TEST_DATA_FOLDER}}/samples' -prune -o \
-                -path './{{.CLANG_FORMAT_INPUT_TEST_DATA_FOLDER}}/samples' -prune -o \
-                -regex ".*[.]md" -print
-            ); do
+          find . \
+            -type d -name ".git" -prune -o \
+            -type d -name ".licenses" -prune -o \
+            -type d -name "__pycache__" -prune -o \
+            -type d -name "node_modules" -prune -o \
+            -path "./{{.CLANG_FORMAT_GOLDEN_TEST_DATA_FOLDER}}/samples" -prune -o \
+            -path "./{{.CLANG_FORMAT_INPUT_TEST_DATA_FOLDER}}/samples" -prune -o \
+            -regex ".*[.]md" \
+            -exec \
               markdown-link-check \
                 --quiet \
                 --config "./.markdown-link-check.json" \
-                "$file"
-              STATUS=$(( $STATUS + $? ))
-            done
-            exit $STATUS
+                \{\} \
+                +
+        else
+          npx --package=markdown-link-check --call='
+            find . \
+              -type d -name ".git" -prune -o \
+              -type d -name ".licenses" -prune -o \
+              -type d -name "__pycache__" -prune -o \
+              -type d -name "node_modules" -prune -o \
+              -path "./{{.CLANG_FORMAT_GOLDEN_TEST_DATA_FOLDER}}/samples" -prune -o \
+              -path "./{{.CLANG_FORMAT_INPUT_TEST_DATA_FOLDER}}/samples" -prune -o \
+              -regex ".*[.]md" \
+              -exec \
+                markdown-link-check \
+                  --quiet \
+                  --config "./.markdown-link-check.json" \
+                  \{\} \
+                  +
           '
         fi
 

workflow-templates/assets/check-markdown-task/Taskfile.yml

@@ -23,46 +23,35 @@ tasks:
             echo "Please install: https://github.com/tcort/markdown-link-check#readme"
             exit 1
           fi
-          # Default behavior of the task on Windows is to exit the task when the first broken link causes a non-zero
-          # exit status, but it's better to check all links before exiting.
-          set +o errexit
-          STATUS=0
           # Using -regex instead of -name to avoid Task's behavior of globbing even when quoted on Windows
           # The odd method for escaping . in the regex is required for windows compatibility because mvdan.cc/sh gives
           # \ characters special treatment on Windows in an attempt to support them as path separators.
-          for file in $(
-            find . \
-              -type d -name '.git' -prune -o \
-              -type d -name '.licenses' -prune -o \
-              -type d -name '__pycache__' -prune -o \
-              -type d -name 'node_modules' -prune -o \
-              -regex ".*[.]md" -print
-          ); do
-            markdown-link-check \
-              --quiet \
-              --config "./.markdown-link-check.json" \
-              "$file"
-            STATUS=$(( $STATUS + $? ))
-          done
-          exit $STATUS
-        else
-          npx --package=markdown-link-check --call='
-            STATUS=0
-            for file in $(
-              find . \
-                -type d -name '.git' -prune -o \
-                -type d -name '.licenses' -prune -o \
-                -type d -name '__pycache__' -prune -o \
-                -type d -name 'node_modules' -prune -o \
-                -regex ".*[.]md" -print
-            ); do
+          find . \
+            -type d -name ".git" -prune -o \
+            -type d -name ".licenses" -prune -o \
+            -type d -name "__pycache__" -prune -o \
+            -type d -name "node_modules" -prune -o \
+            -regex ".*[.]md" \
+            -exec \
               markdown-link-check \
                 --quiet \
                 --config "./.markdown-link-check.json" \
-                "$file"
-              STATUS=$(( $STATUS + $? ))
-            done
-            exit $STATUS
+                \{\} \
+                +
+        else
+          npx --package=markdown-link-check --call='
+            find . \
+              -type d -name ".git" -prune -o \
+              -type d -name ".licenses" -prune -o \
+              -type d -name "__pycache__" -prune -o \
+              -type d -name "node_modules" -prune -o \
+              -regex ".*[.]md" \
+              -exec \
+                markdown-link-check \
+                  --quiet \
+                  --config "./.markdown-link-check.json" \
+                  \{\} \
+                  +
           '
         fi