Removed useless path Clone-ing

cmaglie · cmaglie · commit 202137f9364c · 2022-02-04T16:48:59.000+01:00
Join already creates a copy of the path.
diff --git a/readdir.go b/readdir.go
@@ -40,7 +40,7 @@ func (p *Path) ReadDir() (PathList, error) {
 	}
 	paths := PathList{}
 	for _, info := range infos {
-		path := p.Clone().Join(info.Name())
+		path := p.Join(info.Name())
 		paths.Add(path)
 	}
 	return paths, nil
@@ -55,7 +55,7 @@ func (p *Path) ReadDirRecursive() (PathList, error) {
 	}
 	paths := PathList{}
 	for _, info := range infos {
-		path := p.Clone().Join(info.Name())
+		path := p.Join(info.Name())
 		paths.Add(path)
 
 		if isDir, err := path.IsDirCheck(); err != nil {

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ func (p *Path) ReadDir() (PathList, error) {`
`40`	`40`	`}`
`41`	`41`	`paths := PathList{}`
`42`	`42`	`for _, info := range infos {`
`43`		`- path := p.Clone().Join(info.Name())`
	`43`	`+ path := p.Join(info.Name())`
`44`	`44`	`paths.Add(path)`
`45`	`45`	`}`
`46`	`46`	`return paths, nil`
`@@ -55,7 +55,7 @@ func (p *Path) ReadDirRecursive() (PathList, error) {`
`55`	`55`	`}`
`56`	`56`	`paths := PathList{}`
`57`	`57`	`for _, info := range infos {`
`58`		`- path := p.Clone().Join(info.Name())`
	`58`	`+ path := p.Join(info.Name())`
`59`	`59`	`paths.Add(path)`
`60`	`60`
`61`	`61`	`if isDir, err := path.IsDirCheck(); err != nil {`