Removed unused field/parameter

Author: cmaglie

internal/arduino/builder/builder.go

@@ -190,7 +190,7 @@ func NewBuilder(
 	}
 
 	log := logger.New(stdout, stderr, verbosity, warningsLevel)
-	libsManager, libsResolver, verboseOut, err := detector.LibrariesLoader(
+	libsResolver, verboseOut, err := detector.LibrariesLoader(
 		useCachedLibrariesResolution, librariesManager,
 		builtInLibrariesDirs, libraryDirs, otherLibrariesDirs,
 		actualPlatform, targetPlatform,
@@ -239,7 +239,7 @@ func NewBuilder(
 		),
 		diagnosticStore: diagnosticStore,
 		libsDetector: detector.NewSketchLibrariesDetector(
-			libsManager, libsResolver,
+			libsResolver,
 			useCachedLibrariesResolution,
 			onlyUpdateCompilationDatabase,
 			log,

internal/arduino/builder/internal/detector/detector.go

@@ -49,7 +49,6 @@ type libraryResolutionResult struct {
 
 // SketchLibrariesDetector todo
 type SketchLibrariesDetector struct {
-	librariesManager              *librariesmanager.LibrariesManager
 	librariesResolver             *librariesresolver.Cpp
 	useCachedLibrariesResolution  bool
 	onlyUpdateCompilationDatabase bool
@@ -62,15 +61,13 @@ type SketchLibrariesDetector struct {
 
 // NewSketchLibrariesDetector todo
 func NewSketchLibrariesDetector(
-	lm *librariesmanager.LibrariesManager,
 	libsResolver *librariesresolver.Cpp,
 	useCachedLibrariesResolution bool,
 	onlyUpdateCompilationDatabase bool,
 	logger *logger.BuilderLogger,
 	diagnosticStore *diagnostics.Store,
 ) *SketchLibrariesDetector {
 	return &SketchLibrariesDetector{
-		librariesManager:              lm,
 		librariesResolver:             libsResolver,
 		useCachedLibrariesResolution:  useCachedLibrariesResolution,
 		librariesResolutionResults:    map[string]libraryResolutionResult{},
@@ -598,7 +595,7 @@ func LibrariesLoader(
 	librariesManager *librariesmanager.LibrariesManager,
 	builtInLibrariesDirs *paths.Path, libraryDirs, otherLibrariesDirs paths.PathList,
 	actualPlatform, targetPlatform *cores.PlatformRelease,
-) (*librariesmanager.LibrariesManager, *librariesresolver.Cpp, []byte, error) {
+) (*librariesresolver.Cpp, []byte, error) {
 	verboseOut := &bytes.Buffer{}
 	lm := librariesManager
 	if useCachedLibrariesResolution {
@@ -612,7 +609,7 @@ func LibrariesLoader(
 		builtInLibrariesFolders := builtInLibrariesDirs
 		if builtInLibrariesFolders != nil {
 			if err := builtInLibrariesFolders.ToAbs(); err != nil {
-				return nil, nil, nil, err
+				return nil, nil, err
 			}
 			lmb.AddLibrariesDir(librariesmanager.LibrariesDir{
 				Path:     builtInLibrariesFolders,
@@ -635,7 +632,7 @@ func LibrariesLoader(
 
 		librariesFolders := otherLibrariesDirs
 		if err := librariesFolders.ToAbs(); err != nil {
-			return nil, nil, nil, err
+			return nil, nil, err
 		}
 		for _, folder := range librariesFolders {
 			lmb.AddLibrariesDir(librariesmanager.LibrariesDir{
@@ -667,7 +664,7 @@ func LibrariesLoader(
 
 	allLibs := lm.FindAllInstalled()
 	resolver := librariesresolver.NewCppResolver(allLibs, targetPlatform, actualPlatform)
-	return lm, resolver, verboseOut.Bytes(), nil
+	return resolver, verboseOut.Bytes(), nil
 }
 
 type includeCacheEntry struct {