Bugfix: memory leak caused by variables not being deleted in end(). #192

alranel · facchinm · commit 58136fca1146 · 2022-05-23T09:58:51.000+02:00
diff --git a/src/utility/GATT.cpp b/src/utility/GATT.cpp
@@ -70,7 +70,12 @@ void GATTClass::begin()
 
 void GATTClass::end()
 {
-  _attributes.clear();
+  delete(_genericAccessService);
+  delete(_deviceNameCharacteristic);
+  delete(_appearanceCharacteristic);
+  delete(_genericAttributeService);
+  delete(_servicesChangedCharacteristic);
+  clearAttributes();
 }
 
 void GATTClass::setDeviceName(const char* deviceName)

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,12 @@ void GATTClass::begin()`
`70`	`70`
`71`	`71`	`void GATTClass::end()`
`72`	`72`	`{`
`73`		`- _attributes.clear();`
	`73`	`+ delete(_genericAccessService);`
	`74`	`+ delete(_deviceNameCharacteristic);`
	`75`	`+ delete(_appearanceCharacteristic);`
	`76`	`+ delete(_genericAttributeService);`
	`77`	`+ delete(_servicesChangedCharacteristic);`
	`78`	`+ clearAttributes();`
`74`	`79`	`}`
`75`	`80`
`76`	`81`	`void GATTClass::setDeviceName(const char* deviceName)`