Cannot figure out how to Resolver Composition Transform code to fire.

[Davenporten]

I've been trying to get Resolvers Composition Transform to work and I feel like I must be missing some piece because I cannot get my code that I'm passing to composer to fire. I have

"@graphql-mesh/transform-resolvers-composition": "^0.9.2"

installed and my meshrc has

    transforms:
      - resolversComposition:
          compositions:
            - resolver: "Query.*"
              composer: ./src/is-auth
            - resolver: "Mutation.*"
              composer: ./src/is-auth

I've put my transforms array in both a general scope and on individual sources, but without any luck. My is-auth file is basically just a copy of what is in the docs with just a couple of lines added

module.exports = {
  isAuth: next => (root, args, context, info) => {
      // Check if Authorization header is present
      console.log('isAuth Context', context.authorization)
      context.headers.newThing = 'newThing'
      if(!context.headers.authorization) {
          throw new Error('Unauthorized');
      }
      return next(root, args, context, info);
  }
};

When I run my server and hit different queries and mutations the console.log in the above code never fires and I never see newThing added to the headers. Maybe this is expected? Maybe I'm misunderstanding how this code is meant to be used and am not triggering it properly? My assumption is that when a query (for example) is hit the above code, my new middleware, should run at some point.

Thanks in advance for any help!

@ardatan I'm tagging you in here just because you responded to my issue with getting my meshrc to be valid using this transform (#2081). If you don't have anything for me here no problem of course.

[ardatan]

Could you try it like below? Because it seems you're exporting the function as isAuth named export.

    transforms:
      - resolversComposition:
          compositions:
            - resolver: "Query.*"
              composer: ./src/is-auth#isAuth # << Could you add isAuth?
            - resolver: "Mutation.*"
              composer: ./src/is-auth#isAuth

[Davenporten]

Ah, that makes sense. I thought it was just a comment, but I get what it's doing now. That did it @ardatan! Thanks for all your help!

[hboylan]

This works perfectly for me, but I'm wondering... is it possible to set the status code 401 with the response?

[ardatan]

If you pass response object to the context(Mesh CLI does it), you can do it like below;

module.exports = {
  isAuth: next => (root, args, context, info) => {
      // Check if Authorization header is present
      console.log('isAuth Context', context.authorization)
      context.headers.newThing = 'newThing'
      if(!context.headers.authorization) {
          context.res.send(401, 'Unauthorized');
          context.res.end();
          return;
      }
      return next(root, args, context, info);
  }
};

[hboylan]

Hmm. I gave that a try and received the following warning...

express deprecated res.send(status, body): Use res.status(status).send(body)

I'll take a closer look

[ardatan]

@hboylan res is Express's Response object there :) I have never tried that to be honest. You can check Express docs for more.

[hboylan]

Looks like manipulating context.res has no effect on the final response. The code should be something like:

context.res.status(401)
throw new Error('Unauthorized')

The community also recommends that graphql shouldn't care about the status code. I'll just check the error message to see if it contains "Unauthorized".

[ardatan]

@hboylan I agree with those people actually. You should either have your auth layer above GraphQL layer with the status codes or in your GraphQL layer without dealing with HTTP stuff.