Shouldn't the services.AddTcpProbes take in a int instead of string?

[stijnmoreels]

We currently 'hard-link' the IConfiguration requirement to the adding of TCP health probes in that the TCP port should be in the application configuration. Isn't that a bit outside our responsibility where this port value comes from?

[stijnmoreels]

thoughts, @fgheysels ?

[fgheysels]

You mean that this class has a dependency on IConfiguration and that the health-port needs to be specified under a specific key.
Indeed, it would be better if the TcpHealthListener receives the port itself instead of having to fetch it from the config.

[stijnmoreels]

Yep, that class indeed. Ok, I'll create an issue from this one for a future milestone. 👍