chore: rename the updated atomic to make more sense

Author: owenrumney

pkg/commands/app.go

@@ -243,11 +243,8 @@ func NewRootCommand(globalFlags *flag.GlobalFlagGroup) *cobra.Command {
 			}
 		},
 		PersistentPostRun: func(_ *cobra.Command, _ []string) {
-			if globalFlags.Quiet.Value() || globalFlags.NoNotices.Value() {
-				// don't show alerts during quiet mode
-				// or if the user has disabled notices
-				return
-			}
+			// if the check hasn't run then it will
+			// return immediately and won't print anything
 			update.NotifyUpdates(os.Stderr)
 		},
 	}

pkg/update/check.go

@@ -32,10 +32,10 @@ type updateResponse struct {
 }
 
 var (
-	updatesApi     = "https://api.trivy.cloud/check"
-	updated        atomic.Bool
-	currentVersion string
-	latestVersion  updateResponse
+	updatesApi       = "https://api.trivy.cloud/check"
+	responseRecieved atomic.Bool
+	currentVersion   string
+	latestVersion    updateResponse
 )
 
 // CheckUpdate makes a best efforts request to determine the
@@ -73,19 +73,15 @@ func CheckUpdate(ctx context.Context, version string, args []string) {
 			log.Warnf("Failed to decode the response: %v", err)
 			return
 		}
-		updated.Store(true)
+		responseRecieved.Store(true)
 		log.Debug("[version] Details ready for printing")
 	}()
 }
 
 // NotifyUpdates prints any announcements or warnings
 // to the output writer, most likely stderr
 func NotifyUpdates(output io.Writer) {
-	if !updated.Load() {
-		// the update check didn't happen in time
-		// or it had an error but we don't want to make noise
-		// about it
-		log.Debug("[version] Update check failed or didn't happen in time, check logs for more details")
+	if !responseRecieved.Load() {
 		return
 	}
 

pkg/update/check_test.go

@@ -58,13 +58,13 @@ func TestNotifyUpdates(t *testing.T) {
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			// reset the updated flag
-			updated.Store(false)
+			responseRecieved.Store(false)
 			server := httptest.NewServer(http.HandlerFunc(createHandler(t, tt.latestVersion, tt.announcements)))
 			defer server.Close()
 			updatesApi = server.URL
 
 			CheckUpdate(t.Context(), tt.currentVersion, nil)
-			require.Eventually(t, updated.Load, time.Second*5, 500)
+			require.Eventually(t, responseRecieved.Load, time.Second*5, 500)
 
 			sb := bytes.NewBufferString("")
 			NotifyUpdates(sb)
@@ -102,14 +102,14 @@ func TestCheckUpdate(t *testing.T) {
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			// reset the updated flag
-			updated.Store(false)
+			responseRecieved.Store(false)
 
 			server := httptest.NewServer(http.HandlerFunc(createHandler(t, tt.expectedVersion, tt.expectedAnnouncements)))
 			defer server.Close()
 			updatesApi = server.URL
 
 			CheckUpdate(t.Context(), tt.currentVersion, nil)
-			require.Eventually(t, updated.Load, time.Second*2, 500)
+			require.Eventually(t, responseRecieved.Load, time.Second*2, 500)
 			assert.Equal(t, tt.expectedVersion, latestVersion.Trivy.LatestVersion)
 			assert.ElementsMatch(t, tt.expectedAnnouncements, latestVersion.Announcements)