chore: remove check based on offline scan

offline scan isn't to be included at the moment, this will be tackled
as a different piece of work.

tidied up the notices option to be more consistent with the flag it
reflects

Signed-off-by: Owen Rumney <owen.rumney@aquasec.com>

Author: owenrumney

pkg/commands/artifact/run.go

@@ -118,15 +118,12 @@ func NewRunner(ctx context.Context, cliOptions flag.Options, opts ...RunnerOptio
 		opt(r)
 	}
 
-	// Initialize the version checker
-	if !cliOptions.OfflineScan {
-		// If the user has not disabled notices or is running in quiet mode
-		r.versionChecker = notification.NewVersionChecker(
-			notification.WithSkipUpdateCheck(cliOptions.SkipVersionCheck),
-			notification.WithQuietMode(cliOptions.Quiet),
-			notification.WithTelemetryDisabled(cliOptions.DisableTelemetry),
-		)
-	}
+	// If the user has not disabled notices or is running in quiet mode
+	r.versionChecker = notification.NewVersionChecker(
+		notification.WithSkipVersionCheck(cliOptions.SkipVersionCheck),
+		notification.WithQuietMode(cliOptions.Quiet),
+		notification.WithTelemetryDisabled(cliOptions.DisableTelemetry),
+	)
 
 	// Update the vulnerability database if needed.
 	if err := r.initDB(ctx, cliOptions); err != nil {

pkg/notification/notice_test.go

@@ -43,7 +43,7 @@ func TestPrintNotices(t *testing.T) {
 			name: "new version available but --skip-update-check mode enabled",
 			options: []Option{
 				WithCurrentVersion("0.58.0"),
-				WithSkipUpdateCheck(true),
+				WithSkipVersionCheck(true),
 			},
 			latestVersion:    "0.60.0",
 			responseExpected: false,

pkg/notification/option.go

@@ -16,9 +16,9 @@ func WithCurrentVersion(version string) Option {
 	}
 }
 
-func WithSkipUpdateCheck(skipUpdateCheck bool) Option {
+func WithSkipVersionCheck(skipVersionCheck bool) Option {
 	return func(v *VersionChecker) {
-		v.skipUpdateCheck = skipUpdateCheck
+		v.skipUpdateCheck = skipVersionCheck
 	}
 }