-
Notifications
You must be signed in to change notification settings - Fork 41
Add Suppression Rules Support #272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
If not cloned id and password will be added to json body for all requests Changelog: Fixed
Add GetSuppressionRules, GetSuppressionRule, CreateSuppressionRule, UpdateSuppressionRule, DeleteSuppressionRule, ActivateSuppressionRule and DisableSuppressionRule Changelog: Added
64b3570 to
be3b92a
Compare
…ider Add provider based on new plugin-framework. Mux it with the SDKv2 provider to keep it backwards compatible. Changelog: Added
Add read-only data source to fetch all existing suppression rules Changelog: Added
Add resource to manage suppression rules Changelog: Added
Add suppression rule docs and examples Changelog: Added
be3b92a to
a85c425
Compare
|
@t1edtke |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason why you decided to put your changes under an internal provider?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason why you decided to put your changes under an internal provider?
Thank you for your feedback. The main reason behind my decision is that I chose to implement the new features using the terraform plugin framework. This is the most recent SDK that is easier to use and more extensible than SDKv2. However, there is a separate package required for this. I chose the Would you like this to be changed? |
This pull request introduces support for managing and interacting with suppression rules and closes #260.
Features:
Introduced a new provider based on the Terraform Plugin Framework. The existing SDKv2 provider was muxed with the new provider to ensure backward compatibility.
Added a new read-only data source
suppression_rules, allowing users to fetch and interact with existing suppression rules.Introduced a
suppression_ruleresource that allows users to manage newly created or existing suppression rules.Implemented the following methods in the AquaSec client:
Examples:
Commits: