Merge pull request #72 from aquasecurity/github_first_available_line

davidsalame1 · web-flow · commit e982384fea16 · 2023-06-06T16:20:04.000+03:00
fix bug:() Allow Github FIRST_AVAILABLE_LINE write comment
diff --git a/pkg/commenter/github/github.go b/pkg/commenter/github/github.go
@@ -218,7 +218,7 @@ func (c *Github) writeCommentIfRequired(prComment *github.PullRequestComment) er
 
 // WriteMultiLineComment writes a multiline review on a file in the github PR
 func (c *Github) WriteMultiLineComment(file, comment string, startLine, endLine int) error {
-	if startLine == 0 {
+	if startLine == 0 || startLine == commenter.FIRST_AVAILABLE_LINE {
 		startLine = 1
 	}
 	if endLine == 0 {

Original file line number	Diff line number	Diff line change
`@@ -218,7 +218,7 @@ func (c Github) writeCommentIfRequired(prComment github.PullRequestComment) er`
`218`	`218`
`219`	`219`	`// WriteMultiLineComment writes a multiline review on a file in the github PR`
`220`	`220`	`func (c *Github) WriteMultiLineComment(file, comment string, startLine, endLine int) error {`
`221`		`- if startLine == 0 {`
	`221`	`+ if startLine == 0 \|\| startLine == commenter.FIRST_AVAILABLE_LINE {`
`222`	`222`	`startLine = 1`
`223`	`223`	`}`
`224`	`224`	`if endLine == 0 {`